Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct SQL query pagination for DatasetVersion findAll method #2945

Merged
merged 2 commits into from
Oct 23, 2024
Merged

fix: Correct SQL query pagination for DatasetVersion findAll method #2945

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e27258
fix: Correct SQL query pagination for DatasetVersion findAll method
inanalper Oct 23, 2024
e112c55
Merge branch 'main' into bug/versions-sql-bug
inanalper Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/src/main/java/marquez/db/DatasetVersionDao.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,6 @@ LEFT JOIN (
) f ON f.dataset_version_uuid = dv.uuid
WHERE dv.namespace_name = :namespaceName
AND dv.dataset_name = :datasetName
LIMIT :limit OFFSET :offset
),
dataset_symlinks_names as (
SELECT DISTINCT dataset_uuid, name
Expand All @@ -295,6 +294,7 @@ WHERE name NOT IN (SELECT name FROM dataset_symlinks_names)
created_at, version, dataset_schema_version_uuid, fields, createdByRunUuid, schema_location,
tags, dataset_version_uuid
ORDER BY created_at DESC
LIMIT :limit OFFSET :offset
""")
List<DatasetVersion> findAll(String namespaceName, String datasetName, int limit, int offset);

Expand Down
Loading