Skip to content

Commit

Permalink
Diff demo (#568)
Browse files Browse the repository at this point in the history
* corrected saved report source

* fixed diff display

* no need for leading wildcards

* Allowed multiple diffs

* linked to diff example
  • Loading branch information
therealryan authored Oct 9, 2023
1 parent 5cbf03a commit 93db70e
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
with:
name: flow_execution_reports
path: '**/target/mctf/latest'
path: 'example/**/target/mctf/latest'

- name: Save angular coverage reports
uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
Expand Down
2 changes: 2 additions & 0 deletions doc/src/main/markdown/further.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ The [`Reporting` enum value][Reporting] that you supply controls whether the rep

By default the report will be saved to a timestamped directory under `target/mctf`, but the `mctf.report.dir` system property offers control over the destination directory.

The execution report includes tooling to aid in change review. If the reports generated by your testing are hosted somewhere, (e.g.: by the CI server) then you can link to the model diff in review documentation, [for example](https://github.com/Mastercard/flow/pull/567).

<!-- code_link_start -->

[AbstractFlocessor.reporting(Reporting,String...)]: ../../../../assert/assert-core/src/main/java/com/mastercard/test/flow/assrt/AbstractFlocessor.java#L194-L203,194-203
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@

.diff_display {
display: flex;
flex-wrap: wrap
flex-wrap: wrap;
white-space: break-spaces;
}

.rem {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ <h1>Changed {{changedFlowCount}}</h1>
</mat-panel-description>
</mat-expansion-panel-header>

<mat-accordion id="changes">
<mat-accordion id="changes" multi="true">
<mat-expansion-panel *ngFor="let change of changes">
<mat-expansion-panel-header collapsedHeight="auto" expandedHeight="auto">
<mat-panel-title>
Expand Down Expand Up @@ -123,4 +123,4 @@ <h1>Unchanged {{unchangedEntries.length}}</h1>
</app-flow-nav-list>
</mat-expansion-panel>

</mat-accordion>
</mat-accordion>

0 comments on commit 93db70e

Please sign in to comment.