Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff demo #568

Merged
merged 5 commits into from
Oct 9, 2023
Merged

Diff demo #568

merged 5 commits into from
Oct 9, 2023

Conversation

therealryan
Copy link
Contributor

@therealryan therealryan commented Oct 6, 2023

In #567, we made a change to the example system that resulted in a change to the test-data model.
We manually saved one of the resulting execution reports into the pages branch, resulting in this persistent record of the updated model.

Now we can write documentation about what the model-diff tool does while pointing to a less contrived worked example

In the process we noticed that:

  • Report naming api #559 had created a new execution report that the publish action was picking up. It's not interesting, so we've limited the action to scanning only in the example module.
  • Whitespace was being collapsed in the diff analysis view, leading to "why are these identical-looking changes not being collated?" confusion

Resolves #462

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@therealryan therealryan merged commit 93db70e into main Oct 9, 2023
10 checks passed
@therealryan therealryan deleted the diff_demo branch October 9, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model diff demo
1 participant