Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff demo #568

Merged
merged 5 commits into from
Oct 9, 2023
Merged

Diff demo #568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5eb9f5f
corrected saved report source
therealryan Oct 6, 2023
fb94518
fixed diff display
therealryan Oct 6, 2023
d3bf7e7
no need for leading wildcards
therealryan Oct 6, 2023
d1e5092
Allowed multiple diffs
therealryan Oct 9, 2023
8d4e69f
linked to diff example
therealryan Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
with:
name: flow_execution_reports
path: '**/target/mctf/latest'
path: 'example/**/target/mctf/latest'

- name: Save angular coverage reports
uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
Expand Down
2 changes: 2 additions & 0 deletions doc/src/main/markdown/further.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ The [`Reporting` enum value][Reporting] that you supply controls whether the rep

By default the report will be saved to a timestamped directory under `target/mctf`, but the `mctf.report.dir` system property offers control over the destination directory.

The execution report includes tooling to aid in change review. If the reports generated by your testing are hosted somewhere, (e.g.: by the CI server) then you can link to the model diff in review documentation, [for example](https://github.com/Mastercard/flow/pull/567).

<!-- code_link_start -->

[AbstractFlocessor.reporting(Reporting,String...)]: ../../../../assert/assert-core/src/main/java/com/mastercard/test/flow/assrt/AbstractFlocessor.java#L194-L203,194-203
Expand Down
3 changes: 2 additions & 1 deletion report/report-ng/projects/report/src/app/change-analysis/change-analysis.component.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@

.diff_display {
display: flex;
flex-wrap: wrap
flex-wrap: wrap;
white-space: break-spaces;
}

.rem {
Expand Down
4 changes: 2 additions & 2 deletions report/report-ng/projects/report/src/app/change-analysis/change-analysis.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ <h1>Changed {{changedFlowCount}}</h1>
</mat-panel-description>
</mat-expansion-panel-header>

<mat-accordion id="changes">
<mat-accordion id="changes" multi="true">
<mat-expansion-panel *ngFor="let change of changes">
<mat-expansion-panel-header collapsedHeight="auto" expandedHeight="auto">
<mat-panel-title>
Expand Down Expand Up @@ -123,4 +123,4 @@ <h1>Unchanged {{unchangedEntries.length}}</h1>
</app-flow-nav-list>
</mat-expansion-panel>

</mat-accordion>
</mat-accordion>