Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sequence diagram z-order #265

Closed
therealryan opened this issue Feb 24, 2023 · 10 comments · Fixed by #274
Closed

Sequence diagram z-order #265

therealryan opened this issue Feb 24, 2023 · 10 comments · Fixed by #274
Labels
good first issue Good for newcomers javascript Pull requests that update Javascript code

Comments

@therealryan
Copy link
Contributor

Take a squint at the sequence diagram in this flow detail page, in particular the horizontal message line from QUEUE to CORE - it's rendered as passing under the vertical lines for STORE and DB.

It'd be better if the horizontal line were to be rendered on top.
@therealryan therealryan added good first issue Good for newcomers javascript Pull requests that update Javascript code labels Feb 24, 2023
@therealryan therealryan mentioned this issue Feb 24, 2023
Open
@Chaitu-Tatipamula
Copy link
Contributor

image

is that should be like this

@therealryan
Copy link
Contributor Author

Yeah, we want the black horizontal lines to be drawn on top of the grey vertical lines

@Chaitu-Tatipamula
Copy link
Contributor

Chaitu-Tatipamula commented Feb 24, 2023 •
edited
Loading

where shoul i find the source of this in the repo
ithink the z-index attribute can fix this

Chaitu-Tatipamula added a commit to Chaitu-Tatipamula/flow that referenced this issue Feb 24, 2023
@Chaitu-Tatipamula
Sequence diagram z-order Mastercard#265
4c65d5e
@therealryan
Copy link
Contributor Author

The vertical lines are these divs
The horizontal lines are these divs

@Chaitu-Tatipamula
Copy link
Contributor

Will my commit solve this

@Chaitu-Tatipamula
Copy link
Contributor

Chaitu-Tatipamula commented Feb 24, 2023 •
edited
Loading

image
@therealryan check this out the black ones are on the top...!

Chaitu-Tatipamula added a commit to Chaitu-Tatipamula/flow that referenced this issue Feb 26, 2023
@Chaitu-Tatipamula
Made black ones appear on grey lines Mastercard#265
4bdb4bc 
z-index attribute of the grey lines fixed this issue.
@Chaitu-Tatipamula
Copy link
Contributor

Chaitu-Tatipamula commented Feb 26, 2023 •
edited
Loading

why i was unable to create a pr for this
@therealryan let me know if this was not the solution

@therealryan
Copy link
Contributor Author

@Chaitu-Tatipamula That looks great! I have no idea why you're not able to raise a PR - what happens when you try?
You were able to raise #264, so it shouldn't be a permissions issue.

@Chaitu-Tatipamula
Copy link
Contributor

Chaitu-Tatipamula commented Feb 27, 2023 •
edited
Loading

@therealryan check pr #274

@therealryan
Copy link
Contributor Author

Cheers! I've left a comment on #274 - it looks like you left a change from the log-scrolling issue you worked on before. It probably doesn't belong in a PR for this issue.

@therealryan therealryan linked a pull request Feb 28, 2023 that will close this issue
Made black ones appear on grey lines #265 #274
Merged
therealryan pushed a commit that referenced this issue Feb 28, 2023
@Chaitu-Tatipamula
Made black ones appear on grey lines #265 (#274)
d23ec13 
* Made black ones appear on grey lines #265

z-index attribute of the grey lines fixed this issue.

* Update styles.css
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Made black ones appear on grey lines #265 Chaitu-Tatipamula/flow
2 participants
@therealryan @Chaitu-Tatipamula