Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made black ones appear on grey lines #265 #274

Merged
merged 3 commits into from
Feb 28, 2023

Conversation

Chaitu-Tatipamula
Copy link
Contributor

z-index attribute of the grey lines fixed this issue.

Chaitu-Tatipamula and others added 2 commits February 27, 2023 00:19
@Chaitu-Tatipamula
Copy link
Contributor Author

@therealryan is this the way to raise a PR

Copy link
Contributor

@therealryan therealryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the change to report/report-ng/projects/report/src/styles.css required for the z-order fix? If not, we should remove that change from the PR.

@Chaitu-Tatipamula
Copy link
Contributor Author

Ok ill change and will let you know when done

@therealryan
Copy link
Contributor

A simple way to revert that change would be to run git checkout origin/main report/report-ng/projects/report/src/styles.css and then make a commit as normal.

@Chaitu-Tatipamula
Copy link
Contributor Author

pr #276

@therealryan therealryan self-assigned this Feb 28, 2023
@therealryan therealryan linked an issue Feb 28, 2023 that may be closed by this pull request
@therealryan
Copy link
Contributor

The sonar test is failing, but that's because the fork doesn't have access to the auth token for the upload to sonar. It'd beggar belief that this failure was masking sonar issues in the change.

Copy link
Contributor

@therealryan therealryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@therealryan therealryan merged commit d23ec13 into Mastercard:main Feb 28, 2023
@therealryan
Copy link
Contributor

Congratulations to @Chaitu-Tatipamula for being the first external contributor to this project!
🥇

@Chaitu-Tatipamula
Copy link
Contributor Author

Thank you..😀

@Chaitu-Tatipamula
Copy link
Contributor Author

@therealryan hey can you tell me what this open source is i kinda like this kind of fixing issues but does it really help me for my future career like direct hiring if i really contribute to great projects

@therealryan
Copy link
Contributor

@Chaitu-Tatipamula While I can't really offer useful career advice, it seems to me that having a public history of self-motivated exposure to a bunch of different technologies, problem solving, etc, can only be a good thing.

@Chaitu-Tatipamula
Copy link
Contributor Author

@therealryan thanks for the information ☺️

@therealryan therealryan added the bug Something isn't working label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sequence diagram z-order
2 participants