-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made black ones appear on grey lines #265 #274
Conversation
z-index attribute of the grey lines fixed this issue.
@therealryan is this the way to raise a PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the change to report/report-ng/projects/report/src/styles.css required for the z-order fix? If not, we should remove that change from the PR.
Ok ill change and will let you know when done |
A simple way to revert that change would be to run |
pr #276 |
The sonar test is failing, but that's because the fork doesn't have access to the auth token for the upload to sonar. It'd beggar belief that this failure was masking sonar issues in the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Congratulations to @Chaitu-Tatipamula for being the first external contributor to this project! |
Thank you..😀 |
@therealryan hey can you tell me what this open source is i kinda like this kind of fixing issues but does it really help me for my future career like direct hiring if i really contribute to great projects |
@Chaitu-Tatipamula While I can't really offer useful career advice, it seems to me that having a public history of self-motivated exposure to a bunch of different technologies, problem solving, etc, can only be a good thing. |
@therealryan thanks for the information |
z-index attribute of the grey lines fixed this issue.