[persist / sources] Allow combining batches by default in CI #34224
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAlperin
reviewed
Nov 20, 2025
| ), | ||
| VariableSystemParameter( | ||
| "persist_validate_part_bounds_on_read", "true", ["true", "false"] | ||
| "persist_validate_part_bounds_on_read", "false", ["true", "false"] |
Member
There was a problem hiding this comment.
why change the default to false?
Contributor
Author
There was a problem hiding this comment.
The rollout of this feature involves changing these variables from true (old behaviour) to false (new behaviour), and I want to start getting coverage by default in CI!
(I don't want to change the code default yet, so eg. self-managed users don't get the new behaviour just yet. I don't think these get picked up outside of tests, but cc @def- to confirm!)
Member
There was a problem hiding this comment.
Oh oh yeah you’re right. I had the behavior flipped around. Sorry!
DAlperin
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable a couple flags by default in CI.
Motivation
We're trying to get these more widely rolled out in November.
https://www.notion.so/materialize/Try-to-roll-out-batch-persist-updates-28413f48d37b80bf9a94c443176ed81b
Tips for reviewer
Nightly seems a bit flaky, but failures seem like they may already exist on main. In any case this will be good to get test coverage on!