Skip to content

[persist / sources] Allow combining batches by default in CI #34224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2025
+2 −2
Merged

[persist / sources] Allow combining batches by default in CI #34224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions misc/python/materialize/mzcompose/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,10 +354,10 @@ def get_variable_system_parameters(
"persist_blob_cache_scale_with_threads", "true", ["true", "false"]
),
VariableSystemParameter(
"persist_validate_part_bounds_on_read", "true", ["true", "false"]
"persist_validate_part_bounds_on_read", "false", ["true", "false"]
Copy link
Member

@DAlperin DAlperin Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change the default to false?

Copy link
Contributor Author

@bkirwi bkirwi Nov 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rollout of this feature involves changing these variables from true (old behaviour) to false (new behaviour), and I want to start getting coverage by default in CI!

(I don't want to change the code default yet, so eg. self-managed users don't get the new behaviour just yet. I don't think these get picked up outside of tests, but cc @def- to confirm!)

Copy link
Member

@DAlperin DAlperin Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh oh yeah you’re right. I had the behavior flipped around. Sorry!

),
VariableSystemParameter(
"persist_validate_part_bounds_on_write", "true", ["true", "false"]
"persist_validate_part_bounds_on_write", "false", ["true", "false"]
),
VariableSystemParameter("pg_offset_known_interval", "1s", ["100ms", "1s"]),
VariableSystemParameter(
Expand Down