Added missing species subfields to type list #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
added
priority/low
CasperWA
approved these changes
Sep 14, 2020
There was a problem hiding this comment.
Thanks @ml-evs !
Did you perchance check that any other of the "new" properties added together with attached and nattached were added and older ones removed? There were a lot of last-minute changes, I believe, to species as well as structure_features?
I checked for all subfields of dictionary fields, but that's just |
ml-evs
added a commit
to Materials-Consortia/optimade-python-tools
that referenced
this pull request
Nov 17, 2020
ml-evs
added a commit
to Materials-Consortia/optimade-python-tools
that referenced
this pull request
Nov 17, 2020
ml-evs
added a commit
to Materials-Consortia/optimade-python-tools
that referenced
this pull request
Nov 20, 2020
ml-evs
added a commit
to Materials-Consortia/optimade-python-tools
that referenced
this pull request
Nov 23, 2020
ml-evs
added a commit
to Materials-Consortia/optimade-python-tools
that referenced
this pull request
Nov 25, 2020
* Added missing part of 'species' description from (Materials-Consortia/OPTIMADE#316) * Fixed 'assemblies' description example from (Materials-Consortia/OPTIMADE#338)
ml-evs
added a commit
that referenced
this pull request
Feb 16, 2021
ml-evs
added a commit
that referenced
this pull request
Feb 26, 2021
ml-evs
added a commit
that referenced
this pull request
May 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that
attachedandnattachedare missing from the type list, so this PR adds them.