Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect example in assemblies #338

Merged
merged 2 commits into from
Nov 17, 2020
Merged

Fix incorrect example in assemblies #338

merged 2 commits into from
Nov 17, 2020

Conversation

merkys
Copy link
Member

@merkys merkys commented Nov 17, 2020

Fixes #317

@merkys merkys added the PR/ready-for-review Add this flag if you are the author of the PR and you want it to be reviewed. Remove it when editing label Nov 17, 2020
CasperWA
CasperWA approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright, thanks @merkys !

ml-evs
ml-evs approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted, thanks @merkys.

I'll make the appropriate PR in optimade-python-tools to get this example fixed in our models, and thus our OpenAPI schema, and thus the OpenAPI schema in this repo...

@merkys merkys merged commit 216d7be into develop Nov 17, 2020
@merkys merkys deleted the fix_assemblies_example branch November 17, 2020 11:25
ml-evs added a commit to Materials-Consortia/optimade-python-tools that referenced this pull request Nov 17, 2020
@ml-evs
Fixed 'assemblies' description example from (Materials-Consortia/OPTI…
a063e9d 
…MADE#338)
@merkys
Copy link
Member Author

merkys commented Nov 17, 2020

I'll make the appropriate PR in optimade-python-tools to get this example fixed in our models, and thus our OpenAPI schema, and thus the OpenAPI schema in this repo...

This must be a leftover from the olden times. It would be great to clean it up from OpenAPI schema.

ml-evs added a commit to Materials-Consortia/optimade-python-tools that referenced this pull request Nov 17, 2020
@ml-evs
Fixed 'assemblies' description example from (Materials-Consortia/OPTI…
6fa077b 
…MADE#338)
ml-evs added a commit to Materials-Consortia/optimade-python-tools that referenced this pull request Nov 20, 2020
@ml-evs
Fixed 'assemblies' description example from (Materials-Consortia/OPTI…
9922221 
…MADE#338)
ml-evs added a commit to Materials-Consortia/optimade-python-tools that referenced this pull request Nov 23, 2020
@ml-evs
Fixed 'assemblies' description example from (Materials-Consortia/OPTI…
5e96ac1 
…MADE#338)
ml-evs added a commit to Materials-Consortia/optimade-python-tools that referenced this pull request Nov 25, 2020
@ml-evs
Upstream fixes from specification (#611)
bf1f280 
* Added missing part of 'species' description from (Materials-Consortia/OPTIMADE#316)

* Fixed 'assemblies' description example from (Materials-Consortia/OPTIMADE#338)
@ml-evs ml-evs added this to the 1.0.1 release milestone Feb 26, 2021
rartino pushed a commit that referenced this pull request Jul 7, 2021
@merkys @rartino
Merge pull request #338 from Materials-Consortia/fix_assemblies_example
60ddc2e 
Fix incorrect example in assemblies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ml-evs ml-evs ml-evs approved these changes

@CasperWA CasperWA CasperWA approved these changes

@rartino rartino Awaiting requested review from rartino

Assignees
No one assigned
Labels
PR/ready-for-review Add this flag if you are the author of the PR and you want it to be reviewed. Remove it when editing
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

Incorrect representation of species in example for assemblies
3 participants
@merkys @ml-evs @CasperWA