Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add field for implementation issue tracker #339

Merged
merged 3 commits into from
Nov 17, 2020
Merged

Add field for implementation issue tracker #339

merged 3 commits into from
Nov 17, 2020

Conversation

merkys
Copy link
Member

@merkys merkys commented Nov 17, 2020

Fixes #337

@merkys merkys added the PR/ready-for-review Add this flag if you are the author of the PR and you want it to be reviewed. Remove it when editing label Nov 17, 2020
CasperWA
CasperWA requested changes Nov 17, 2020
View reviewed changes
Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extremely minor change request and then good to go on my part, thanks @merkys !

optimade.rst Outdated Show resolved Hide resolved
@merkys @CasperWA
Update optimade.rst
558a71b 
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
CasperWA
CasperWA approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @merkys !

@CasperWA CasperWA mentioned this pull request Nov 17, 2020
Closed
ml-evs
ml-evs approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this idea, thanks for working it up @merkys.

@merkys merkys merged commit 3cd5936 into develop Nov 17, 2020
@merkys merkys deleted the add_issue_tracker branch November 17, 2020 11:06
@merkys
Copy link
Member Author

merkys commented Nov 17, 2020

I really like this idea, thanks for working it up @merkys.

Thanks @CasperWA for coming up with it in #337 in first place! :)

ml-evs added a commit to Materials-Consortia/optimade-python-tools that referenced this pull request Nov 17, 2020
@ml-evs
Added 'issue_tracker' field from (Materials-Consortia/OPTIMADE#339)
1484464
ml-evs added a commit to Materials-Consortia/optimade-python-tools that referenced this pull request Nov 17, 2020
@ml-evs
Added 'issue_tracker' field from (Materials-Consortia/OPTIMADE#339)
7c3eb90
ml-evs added a commit to Materials-Consortia/optimade-python-tools that referenced this pull request Nov 20, 2020
@ml-evs
Added 'issue_tracker' field from (Materials-Consortia/OPTIMADE#339)
e8a79c8
@merkys merkys mentioned this pull request Nov 20, 2020
Open
ml-evs added a commit to Materials-Consortia/optimade-python-tools that referenced this pull request Nov 23, 2020
@ml-evs
Added 'issue_tracker' field from (Materials-Consortia/OPTIMADE#339)
b5cdeae
@ml-evs ml-evs modified the milestones: 1.0.1 release, 1.1 release Feb 26, 2021
@ml-evs ml-evs mentioned this pull request Feb 26, 2021
Closed
CasperWA pushed a commit to Materials-Consortia/optimade-python-tools that referenced this pull request Jul 6, 2021
@ml-evs
Add issue_tracker field to provider model - Update OPTIMADE API to v1…
5e3e45e 
….1 (#593)

Added 'issue_tracker' field from
Materials-Consortia/OPTIMADE#339
Add default values for issue_tracker to configuration files.

Bump OPTIMADE version to v1.1.0 and fix README.
@ml-evs ml-evs modified the milestones: v1.2, v1.1 Jul 7, 2021
@rartino rartino mentioned this pull request Jul 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CasperWA CasperWA CasperWA approved these changes

@ml-evs ml-evs ml-evs approved these changes

@rartino rartino Awaiting requested review from rartino

@shyamd shyamd Awaiting requested review from shyamd

Assignees
No one assigned
Labels
PR/ready-for-review Add this flag if you are the author of the PR and you want it to be reviewed. Remove it when editing
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

New issue_tracker field in meta->provider?
3 participants
@merkys @ml-evs @CasperWA