-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add issue_tracker field to provider model #593
Conversation
Codecov Report
@@ Coverage Diff @@
## master #593 +/- ##
=======================================
Coverage 92.69% 92.69%
=======================================
Files 67 67
Lines 3752 3753 +1
=======================================
+ Hits 3478 3479 +1
Misses 274 274
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
6fa077b
to
9922221
Compare
I'm considering splitting this PR into "fixes" and "features" following the comments around maintaining two parallel releases of the specification. We should have a discussion about how we want to version our models in the future. Is the API stable enough to be able to pluck the models out into a separate repository where they can be versioned as releases, or does this add too much overhead on what will hopefully be fairly static objects? [additionally two model versions could not be used simultaneously with this approach] Should we explicitly add logic for versioning models in this package, e.g. extend I'll raise an issue on this. |
9922221
to
b5cdeae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay :)
However! We should probably change our "supported specification version" to v1.0.0~develop
?
Indeed, this version splitting may pose some problems, as I believe you also point out?
Yeah, I think this is blocked until we discuss #609 (and discuss spec versioning in the meeting today). |
As it looks like OPTIMADE 1.0.1 will not exist, we need to update our package to the imminent 1.1.0 and fix our descriptions. I think I have done this in a10e6bb |
This also sets off a cascade of schema updates (that we already tried to pre-empt for v1.0.1...). We will need to make a PR with these schemas into the spec repo before v1.1.0 can be released. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't know we hadn't included issue_tracker
yet 😮
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final suggestion - also, is there not also a test config file to add issue_tracker
to, or maybe it doesn't really matter...?
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get in!
This PR begins tracking changes to the specification beyond v1.0. We may consider maintaining this as a separate branch, or versioning our models in another way (see #609).
issue_tracker
field for providers, closes Incoming model update (new field: issue_tracker) #592