Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new member function to the Parameters class. It is called
find_variable_index
. This function behaves exactly like the already-existingParameters.find_index
except it will return -1 when the input string is not in theuser_parameters
. For developers, such as PhysiPKPD, relying onuser_parameters
to make their code run, this gives the ability to protect their end users from missing parameters and typos.By contrast,
find_index
would add the missing string to the keys of the unordered_map and assign it the default value of 0. That means the call to the missing parameter will actually return the value of the parameter (of the same type) with index 0 without warning.There are two reasons for the similarity between the names
find_variable_index
andfind_index
.find_variable_index
is analogous to the member function of Custom_Cell_Data class of the same name, which may help coders distinguish the two a little bit.