Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable building DLL on Windows #187

Merged
merged 2 commits into from
Dec 28, 2023
Merged

Disable building DLL on Windows #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a8a1ed
disable building dynamic libraries on Windows
robUx4 Dec 28, 2023
0aa3eb2
CI: don't build Windows DLLs anymore
robUx4 Dec 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions .github/workflows/windows.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,12 @@ on:

jobs:
build_libebml:
name: libebml ${{ matrix.arch.name }} ${{ matrix.config }} ${{ matrix.shared.name }}
name: libebml ${{ matrix.arch.name }} ${{ matrix.config }}
runs-on: windows-latest
strategy:
fail-fast: false
matrix:
config: [Debug, Release]
shared: [
{ "name": "Dynamic", "option": "ON"},
{ "name": "Static", "option": "OFF"}
]
arch: [
{ "name": "x64", "option": "x64", "env": "AMD64"},
{ "name": "x86", "option": "win32", "env": "X86"},
Expand All @@ -30,8 +26,8 @@ jobs:
- name: Get pushed code
uses: actions/checkout@v3

- name: Configure ${{ matrix.shared.name }} library
run: cmake -S . -B _build ${{ env.CMAKE_OPTIONS }} -A ${{ matrix.arch.option }} -DBUILD_SHARED_LIBS=${{ matrix.shared.option }}
- name: Configure library
run: cmake -S . -B _build ${{ env.CMAKE_OPTIONS }} -A ${{ matrix.arch.option }}

- name: Build
run: cmake --build _build --config ${{ matrix.config }} --parallel
Expand Down
4 changes: 3 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@ cmake_minimum_required(VERSION 3.1.2)

project(ebml VERSION 2.0.0)

include(CMakeDependentOption)

option(DISABLE_PKGCONFIG "Disable PkgConfig module generation" OFF)
option(DISABLE_CMAKE_CONFIG "Disable CMake package config module generation" OFF)
option(BUILD_SHARED_LIBS "Build libebml as a shared library" OFF)
cmake_dependent_option(BUILD_SHARED_LIBS "Build libebml as a shared library (except Windows)" OFF "NOT WIN32" OFF)
option(BUILD_TESTING "Build tests" OFF)

include(GNUInstallDirs)
Expand Down