Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use templates to factorize generic code #200

Merged
merged 11 commits into from
Jan 1, 2024
Merged

Use templates to factorize generic code #200

merged 11 commits into from
Jan 1, 2024

Conversation

robUx4
Copy link
Contributor

@robUx4 robUx4 commented Dec 31, 2023

Followup to #186

@robUx4 robUx4 added api-break breaks the API (e.g. programs using it will have to adjust their source code) abi-break breaks the ABI (e.g. programs linked against the library have to be recompiled) labels Dec 31, 2023
@robUx4 robUx4 mentioned this pull request Dec 31, 2023
Merged
@robUx4
make SetValue return a typed template
c5cbeb3 
The less generic it is, the less errors we can get.
@robUx4
make the SetValue(T) mandatory for all EbmlElementDefault classes
a2bced7
@robUx4
Use a typed class to store the Value
7d969ec
@robUx4
Use a typed class to store the Value with a different type than the d…
d289df7 
…efault type

std::string can only be a constexpr in C++20 so we use (wide)char constants for default values.
@robUx4
factorize the SetValue in the relevant classes
6577c79
@robUx4
factorize the SetValue with a different storage than the constexpr one
b1773c4
@robUx4
factorize operator==() for the constexpr type
f47d983
@robUx4
factorize GetValue() for the constexpr type
750d1e0
@robUx4
factorize GetValue() for the non-const type
432529f
@robUx4
factorize IsSmallerThan() for the constexpr type
7497a3d
@robUx4
factorize the operator to get the usable type for the non-const type
73a2bcb
@robUx4 robUx4 marked this pull request as ready for review January 1, 2024 15:43
mbunkus
mbunkus approved these changes Jan 1, 2024
View reviewed changes
Copy link
Contributor

@mbunkus mbunkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both LGTM & PMTS (Passes MKVToolNix Test Suite) 😁 Please merge.

@mbunkus mbunkus merged commit a681153 into Matroska-Org:master Jan 1, 2024
15 checks passed
@mbunkus
Copy link
Contributor

mbunkus commented Jan 1, 2024

…or I can just merge myself. No reason not to when we're the only two people consistently working on this stuff anyway 😁

@robUx4 robUx4 deleted the typed_values branch January 2, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbunkus mbunkus mbunkus approved these changes

Assignees
No one assigned
Labels
abi-break breaks the ABI (e.g. programs linked against the library have to be recompiled) api-break breaks the API (e.g. programs using it will have to adjust their source code)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robUx4 @mbunkus