Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use templates to factorize generic code #200

Merged
merged 11 commits into from
Jan 1, 2024
Merged

Use templates to factorize generic code #200

merged 11 commits into from
Jan 1, 2024

Commits on Jan 1, 2024

  1. make SetValue return a typed template 

    The less generic it is, the less errors we can get.
    @robUx4
    robUx4 committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    c5cbeb3 View commit details
    Browse the repository at this point in the history

  2. make the SetValue(T) mandatory for all EbmlElementDefault classes

    @robUx4
    robUx4 committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    a2bced7 View commit details
    Browse the repository at this point in the history

  3. Use a typed class to store the Value

    @robUx4
    robUx4 committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    7d969ec View commit details
    Browse the repository at this point in the history

  4. Use a typed class to store the Value with a different type than the d… 

    …efault type

std::string can only be a constexpr in C++20 so we use (wide)char constants for default values.
    @robUx4
    robUx4 committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    d289df7 View commit details
    Browse the repository at this point in the history

  5. factorize the SetValue in the relevant classes

    @robUx4
    robUx4 committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    6577c79 View commit details
    Browse the repository at this point in the history

  6. factorize the SetValue with a different storage than the constexpr one

    @robUx4
    robUx4 committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    b1773c4 View commit details
    Browse the repository at this point in the history

  7. factorize operator==() for the constexpr type

    @robUx4
    robUx4 committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    f47d983 View commit details
    Browse the repository at this point in the history

  8. factorize GetValue() for the constexpr type

    @robUx4
    robUx4 committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    750d1e0 View commit details
    Browse the repository at this point in the history

  9. factorize GetValue() for the non-const type

    @robUx4
    robUx4 committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    432529f View commit details
    Browse the repository at this point in the history

  10. factorize IsSmallerThan() for the constexpr type

    @robUx4
    robUx4 committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    7497a3d View commit details
    Browse the repository at this point in the history

  11. factorize the operator to get the usable type for the non-const type

    @robUx4
    robUx4 committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    73a2bcb View commit details
    Browse the repository at this point in the history