Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass std::function by const ref #231

Merged
merged 3 commits into from
Jan 28, 2024
Merged

pass std::function by const ref #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a051979
change UpdateSize to pass const ref
neheb Jan 28, 2024
96b2984
clang-tidy: performance fixes
neheb Jan 26, 2024
2160568
RenderData: change param to const ref
neheb Jan 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ebml/EbmlBinary.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ class EBML_DLL_API EbmlBinary : public EbmlElement {

bool SizeIsValid(std::uint64_t size) const override {return size < 0x7FFFFFFF;} // we don't mind about what's inside

filepos_t RenderData(IOCallback & output, bool bForceRender, ShouldWrite writeFilter = WriteSkipDefault) override;
filepos_t RenderData(IOCallback & output, bool bForceRender, const ShouldWrite & writeFilter = WriteSkipDefault) override;
filepos_t ReadData(IOCallback & input, ScopeMode ReadFully = SCOPE_ALL_DATA) override;
filepos_t UpdateSize(ShouldWrite writeFilter = WriteSkipDefault, bool bForceRender = false) override;
filepos_t UpdateSize(const ShouldWrite & writeFilter = WriteSkipDefault, bool bForceRender = false) override;

void SetBuffer(const binary *Buffer, const std::uint32_t BufferSize) {
Data = const_cast<binary *>(Buffer);
Expand Down
4 changes: 2 additions & 2 deletions ebml/EbmlCrc32.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ namespace libebml {

DECLARE_EBML_BINARY_LENGTH(EbmlCrc32, 4)
public:
filepos_t RenderData(IOCallback & output, bool bForceRender, ShouldWrite writeFilter = WriteSkipDefault) override;
filepos_t RenderData(IOCallback & output, bool bForceRender, const ShouldWrite & writeFilter = WriteSkipDefault) override;
filepos_t ReadData(IOCallback & input, ScopeMode ReadFully = SCOPE_ALL_DATA) override;
// filepos_t UpdateSize(ShouldWrite writeFilter = WriteSkipDefault);
// filepos_t UpdateSize(const ShouldWrite & writeFilter = WriteSkipDefault) override;

bool IsDefaultValue() const override {
return false;
Expand Down
4 changes: 2 additions & 2 deletions ebml/EbmlDate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class EBML_DLL_API EbmlDate : public EbmlElementDefaultSameStorage<std::int64_t>
/*!
\note no Default date handled
*/
filepos_t UpdateSize(ShouldWrite /* writeFilter */, bool /* bForceRender = false */) override {
filepos_t UpdateSize(const ShouldWrite & /* writeFilter */, bool /* bForceRender = false */) override {
if(!ValueIsSet())
SetSize_(0);
else
Expand All @@ -68,7 +68,7 @@ class EBML_DLL_API EbmlDate : public EbmlElementDefaultSameStorage<std::int64_t>
}

private:
filepos_t RenderData(IOCallback & output, bool bForceRender, ShouldWrite writeFilter = WriteSkipDefault) override;
filepos_t RenderData(IOCallback & output, bool bForceRender, const ShouldWrite & writeFilter = WriteSkipDefault) override;

static constexpr std::uint64_t UnixEpochDelay = 978'307'200; // 2001/01/01 00:00:00 UTC
};
Expand Down
14 changes: 7 additions & 7 deletions ebml/EbmlElement.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,11 +516,11 @@ class EBML_DLL_API EbmlElement {
return ElementPosition;
}

std::uint64_t ElementSize(ShouldWrite writeFilter = WriteSkipDefault) const; /// return the size of the header+data, before writing
std::uint64_t ElementSize(const ShouldWrite& writeFilter = WriteSkipDefault) const; /// return the size of the header+data, before writing

filepos_t Render(IOCallback & output, ShouldWrite writeFilter = WriteSkipDefault, bool bKeepPosition = false, bool bForceRender = false);
filepos_t Render(IOCallback & output, const ShouldWrite& writeFilter = WriteSkipDefault, bool bKeepPosition = false, bool bForceRender = false);

virtual filepos_t UpdateSize(ShouldWrite writeFilter = WriteSkipDefault, bool bForceRender = false) = 0; /// update the Size of the Data stored
virtual filepos_t UpdateSize(const ShouldWrite & writeFilter = WriteSkipDefault, bool bForceRender = false) = 0; /// update the Size of the Data stored
virtual filepos_t GetSize() const {return Size;} /// return the size of the data stored in the element, on reading

virtual filepos_t ReadData(IOCallback & input, ScopeMode ReadFully = SCOPE_ALL_DATA) = 0;
Expand Down Expand Up @@ -551,7 +551,7 @@ class EBML_DLL_API EbmlElement {
/*!
\brief void the content of the element (replace by EbmlVoid)
*/
std::uint64_t VoidMe(IOCallback & output, ShouldWrite writeFilter = WriteSkipDefault) const;
std::uint64_t VoidMe(IOCallback & output, const ShouldWrite& writeFilter = WriteSkipDefault) const;

virtual bool IsDefaultValue() const = 0;
bool IsFiniteSize() const {return bSizeIsFinite;}
Expand All @@ -568,7 +568,7 @@ class EBML_DLL_API EbmlElement {
return SizePosition + CodedSizeLength(Size, SizeLength, bSizeIsFinite) + Size;
}

virtual bool CanWrite(ShouldWrite & writeFilter) const {
virtual bool CanWrite(const ShouldWrite & writeFilter) const {
return writeFilter(*this);
}

Expand All @@ -581,13 +581,13 @@ class EBML_DLL_API EbmlElement {
bool AsInfiniteSize,
bool bAllowDummy = false, unsigned int MaxLowerLevel = 1);

filepos_t RenderHead(IOCallback & output, bool bForceRender, ShouldWrite writeFilter = WriteSkipDefault, bool bKeepPosition = false);
filepos_t RenderHead(IOCallback & output, bool bForceRender, const ShouldWrite& writeFilter = WriteSkipDefault, bool bKeepPosition = false);
filepos_t MakeRenderHead(IOCallback & output, bool bKeepPosition);

/*!
\brief prepare the data before writing them (in case it's not already done by default)
*/
virtual filepos_t RenderData(IOCallback & output, bool bForceRender, ShouldWrite writeFilter = WriteSkipDefault) = 0;
virtual filepos_t RenderData(IOCallback & output, bool bForceRender, const ShouldWrite & writeFilter = WriteSkipDefault) = 0;

/*!
\brief special constructor for cloning
Expand Down
4 changes: 2 additions & 2 deletions ebml/EbmlFloat.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@ class EBML_DLL_API EbmlFloat : public EbmlElementDefaultSameStorage<double> {
return (size == 4 || size == 8);
}

filepos_t RenderData(IOCallback & output, bool bForceRender, ShouldWrite writeFilter = WriteSkipDefault) override;
filepos_t RenderData(IOCallback & output, bool bForceRender, const ShouldWrite & writeFilter = WriteSkipDefault) override;
filepos_t ReadData(IOCallback & input, ScopeMode ReadFully = SCOPE_ALL_DATA) override;
filepos_t UpdateSize(ShouldWrite writeFilter = WriteSkipDefault, bool bForceRender = false) override;
filepos_t UpdateSize(const ShouldWrite & writeFilter = WriteSkipDefault, bool bForceRender = false) override;

void SetPrecision(const EbmlFloat::Precision prec = FLOAT_32)
{
Expand Down
6 changes: 3 additions & 3 deletions ebml/EbmlMaster.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ class EBML_DLL_API EbmlMaster : public EbmlElement {
*/
~EbmlMaster() override;

filepos_t RenderData(IOCallback & output, bool bForceRender, ShouldWrite writeFilter = WriteSkipDefault) override;
filepos_t RenderData(IOCallback & output, bool bForceRender, const ShouldWrite & writeFilter = WriteSkipDefault) override;
filepos_t ReadData(IOCallback & input, ScopeMode ReadFully) override;
filepos_t UpdateSize(ShouldWrite writeFilter = WriteSkipDefault, bool bForceRender = false) override;
filepos_t UpdateSize(const ShouldWrite & writeFilter = WriteSkipDefault, bool bForceRender = false) override;

bool PushElement(EbmlElement & element);
std::uint64_t GetSize() const override {
Expand Down Expand Up @@ -127,7 +127,7 @@ class EBML_DLL_API EbmlMaster : public EbmlElement {
/*!
\brief facility for Master elements to write only the head and force the size later
*/
filepos_t WriteHead(IOCallback & output, int SizeLength, ShouldWrite writeFilter = WriteSkipDefault);
filepos_t WriteHead(IOCallback & output, int SizeLength, const ShouldWrite& writeFilter = WriteSkipDefault);

void EnableChecksum(bool bIsEnabled = true) { bChecksumUsed = bIsEnabled; }
bool HasChecksum() const {return bChecksumUsed;}
Expand Down
4 changes: 2 additions & 2 deletions ebml/EbmlSInteger.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ class EBML_DLL_API EbmlSInteger : public EbmlElementDefaultSameStorage<std::int6
void SetDefaultSize(std::uint64_t nDefaultSize = DEFAULT_INT_SIZE) override {EbmlElement::SetDefaultSize(nDefaultSize); SetSize_(nDefaultSize);}

bool SizeIsValid(std::uint64_t size) const override {return size <= 8;}
filepos_t RenderData(IOCallback & output, bool bForceRender, ShouldWrite writeFilter = WriteSkipDefault) override;
filepos_t RenderData(IOCallback & output, bool bForceRender, const ShouldWrite & writeFilter = WriteSkipDefault) override;
filepos_t ReadData(IOCallback & input, ScopeMode ReadFully = SCOPE_ALL_DATA) override;
filepos_t UpdateSize(ShouldWrite writeFilter = WriteSkipDefault, bool bForceRender = false) override;
filepos_t UpdateSize(const ShouldWrite & writeFilter = WriteSkipDefault, bool bForceRender = false) override;

using EbmlElement::operator const EbmlId &;
explicit operator std::int8_t() const;
Expand Down
4 changes: 2 additions & 2 deletions ebml/EbmlString.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ class EBML_DLL_API EbmlString : public EbmlElementDefaultStorage<const char *, s
EbmlString(const EbmlCallbacksDefault<const char *> &);

bool SizeIsValid(std::uint64_t size) const override {return size < 0x7FFFFFFF;} // any size is possible
filepos_t RenderData(IOCallback & output, bool bForceRender, ShouldWrite writeFilter = WriteSkipDefault) override;
filepos_t RenderData(IOCallback & output, bool bForceRender, const ShouldWrite & writeFilter = WriteSkipDefault) override;
filepos_t ReadData(IOCallback & input, ScopeMode ReadFully = SCOPE_ALL_DATA) override;
filepos_t UpdateSize(ShouldWrite writeFilter = WriteSkipDefault, bool bForceRender = false) override;
filepos_t UpdateSize(const ShouldWrite & writeFilter = WriteSkipDefault, bool bForceRender = false) override;

using EbmlElement::operator const EbmlId &;

Expand Down
4 changes: 2 additions & 2 deletions ebml/EbmlUInteger.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@ class EBML_DLL_API EbmlUInteger : public EbmlElementDefaultSameStorage<std::uint
void SetDefaultSize(std::uint64_t nDefaultSize = DEFAULT_UINT_SIZE) override {EbmlElement::SetDefaultSize(nDefaultSize); SetSize_(nDefaultSize);}

bool SizeIsValid(std::uint64_t size) const override {return size <= 8;}
filepos_t RenderData(IOCallback & output, bool bForceRender, ShouldWrite writeFilter = WriteSkipDefault) override;
filepos_t RenderData(IOCallback & output, bool bForceRender, const ShouldWrite & writeFilter = WriteSkipDefault) override;
filepos_t ReadData(IOCallback & input, ScopeMode ReadFully = SCOPE_ALL_DATA) override;
filepos_t UpdateSize(ShouldWrite writeFilter = WriteSkipDefault, bool bForceRender = false) override;
filepos_t UpdateSize(const ShouldWrite & writeFilter = WriteSkipDefault, bool bForceRender = false) override;

using EbmlElement::operator const EbmlId &;
explicit operator std::uint8_t() const;
Expand Down
4 changes: 2 additions & 2 deletions ebml/EbmlUnicodeString.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@ class EBML_DLL_API EbmlUnicodeString : public EbmlElementDefaultStorage<const wc
EbmlUnicodeString(const EbmlCallbacksDefault<const wchar_t *> &);

bool SizeIsValid(std::uint64_t /*size*/) const override {return true;} // any size is possible
filepos_t RenderData(IOCallback & output, bool bForceRender, ShouldWrite writeFilter = WriteSkipDefault) override;
filepos_t RenderData(IOCallback & output, bool bForceRender, const ShouldWrite & writeFilter = WriteSkipDefault) override;
filepos_t ReadData(IOCallback & input, ScopeMode ReadFully = SCOPE_ALL_DATA) override;
filepos_t UpdateSize(ShouldWrite writeFilter = WriteSkipDefault, bool bForceRender = false) override;
filepos_t UpdateSize(const ShouldWrite & writeFilter = WriteSkipDefault, bool bForceRender = false) override;

using EbmlElement::operator const EbmlId &;

Expand Down
6 changes: 3 additions & 3 deletions ebml/EbmlVoid.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,17 @@ DECLARE_EBML_BINARY(EbmlVoid)
/*!
\note overwrite to write fake data
*/
filepos_t RenderData(IOCallback & output, bool bForceRender, ShouldWrite writeFilter = WriteSkipDefault) override;
filepos_t RenderData(IOCallback & output, bool bForceRender, const ShouldWrite & writeFilter = WriteSkipDefault) override;

/*!
\brief Replace the void element content (written) with this one
*/
std::uint64_t ReplaceWith(EbmlElement & EltToReplaceWith, IOCallback & output, bool ComeBackAfterward = true, ShouldWrite writeFilter = WriteSkipDefault);
std::uint64_t ReplaceWith(EbmlElement & EltToReplaceWith, IOCallback & output, bool ComeBackAfterward = true, const ShouldWrite& writeFilter = WriteSkipDefault);

/*!
\brief Void the content of an element
*/
std::uint64_t Overwrite(const EbmlElement & EltToVoid, IOCallback & output, bool ComeBackAfterward = true, ShouldWrite writeFilter = WriteSkipDefault);
std::uint64_t Overwrite(const EbmlElement & EltToVoid, IOCallback & output, bool ComeBackAfterward = true, const ShouldWrite& writeFilter = WriteSkipDefault);

EBML_CONCRETE_CLASS(EbmlVoid)
};
Expand Down
4 changes: 2 additions & 2 deletions src/EbmlBinary.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ EbmlBinary::~EbmlBinary() {
EbmlBinary::operator const binary &() const {return *Data;}


filepos_t EbmlBinary::RenderData(IOCallback & output, bool /* bForceRender */, ShouldWrite /* writeFilter */)
filepos_t EbmlBinary::RenderData(IOCallback & output, bool /* bForceRender */, const ShouldWrite & /* writeFilter */)
{
output.writeFully(Data,GetSize());

Expand All @@ -59,7 +59,7 @@ filepos_t EbmlBinary::RenderData(IOCallback & output, bool /* bForceRender */, S
/*!
\note no Default binary value handled
*/
std::uint64_t EbmlBinary::UpdateSize(ShouldWrite /* writeFilter */, bool /* bForceRender */)
std::uint64_t EbmlBinary::UpdateSize(const ShouldWrite & /* writeFilter */, bool /* bForceRender */)
{
return GetSize();
}
Expand Down
2 changes: 1 addition & 1 deletion src/EbmlCrc32.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ bool EbmlCrc32::CheckElementCRC32(EbmlElement &ElementToCRC) const
return CheckCRC(m_crc_final, memoryBuffer.GetDataBuffer(), static_cast<std::uint32_t>(memSize));
}

filepos_t EbmlCrc32::RenderData(IOCallback & output, bool /* bForceRender */, ShouldWrite /* writeFilter */)
filepos_t EbmlCrc32::RenderData(IOCallback & output, bool /* bForceRender */, const ShouldWrite & /* writeFilter */)
{
filepos_t Result = 4;

Expand Down
2 changes: 1 addition & 1 deletion src/EbmlDate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ filepos_t EbmlDate::ReadData(IOCallback & input, ScopeMode ReadFully)
return GetSize();
}

filepos_t EbmlDate::RenderData(IOCallback & output, bool /* bForceRender */, ShouldWrite /* writeFilter */)
filepos_t EbmlDate::RenderData(IOCallback & output, bool /* bForceRender */, const ShouldWrite & /* writeFilter */)
{
assert(GetSize() == 8 || GetSize() == 0);
if (GetSize() == 8) {
Expand Down
8 changes: 4 additions & 4 deletions src/EbmlElement.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ EbmlElement *EbmlElement::CreateElementUsingContext(const EbmlId & aID, const Eb
/*!
\todo verify that the size written is the same as the data written
*/
filepos_t EbmlElement::Render(IOCallback & output, ShouldWrite writeFilter, bool bKeepPosition, bool bForceRender)
filepos_t EbmlElement::Render(IOCallback & output, const ShouldWrite& writeFilter, bool bKeepPosition, bool bForceRender)
{
assert(bValueIsSet || CanWrite(writeFilter)); // an element is been rendered without a value set !!!
// it may be a mandatory element without a default value
Expand All @@ -513,7 +513,7 @@ filepos_t EbmlElement::Render(IOCallback & output, ShouldWrite writeFilter, bool
\todo handle exceptions on errors
\todo handle CodeSize bigger than 5 bytes
*/
filepos_t EbmlElement::RenderHead(IOCallback & output, bool bForceRender, ShouldWrite writeFilter, bool bKeepPosition)
filepos_t EbmlElement::RenderHead(IOCallback & output, bool bForceRender, const ShouldWrite& writeFilter, bool bKeepPosition)
{
if (EBML_ID_LENGTH((const EbmlId&)*this) <= 0 || EBML_ID_LENGTH((const EbmlId&)*this) > 4)
return 0;
Expand Down Expand Up @@ -544,7 +544,7 @@ filepos_t EbmlElement::MakeRenderHead(IOCallback & output, bool bKeepPosition)
return FinalHeadSize;
}

std::uint64_t EbmlElement::ElementSize(ShouldWrite writeFilter) const
std::uint64_t EbmlElement::ElementSize(const ShouldWrite& writeFilter) const
{
if (!CanWrite(writeFilter))
return 0; // won't be saved
Expand Down Expand Up @@ -622,7 +622,7 @@ filepos_t EbmlElement::OverwriteData(IOCallback & output, bool bKeepPosition)
}


std::uint64_t EbmlElement::VoidMe(IOCallback & output, ShouldWrite writeFilter) const
std::uint64_t EbmlElement::VoidMe(IOCallback & output, const ShouldWrite& writeFilter) const
{
if (ElementPosition == 0) {
return 0; // the element has not been written
Expand Down
4 changes: 2 additions & 2 deletions src/EbmlFloat.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ EbmlFloat::operator double() const {return (GetValue());}
\todo handle exception on errors
\todo handle 10 bits precision
*/
filepos_t EbmlFloat::RenderData(IOCallback & output, bool /* bForceRender */, ShouldWrite /* writeFilter */)
filepos_t EbmlFloat::RenderData(IOCallback & output, bool /* bForceRender */, const ShouldWrite & /* writeFilter */)
{
assert(GetSize() == 4 || GetSize() == 8);

Expand All @@ -53,7 +53,7 @@ filepos_t EbmlFloat::RenderData(IOCallback & output, bool /* bForceRender */, Sh
return GetSize();
}

std::uint64_t EbmlFloat::UpdateSize(ShouldWrite writeFilter, bool /* bForceRender */)
std::uint64_t EbmlFloat::UpdateSize(const ShouldWrite & writeFilter, bool /* bForceRender */)
{
if (!CanWrite(writeFilter))
return 0;
Expand Down
6 changes: 3 additions & 3 deletions src/EbmlMaster.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ EbmlMaster::~EbmlMaster()
\todo handle exception on errors
\todo write all the Mandatory elements in the Context, otherwise assert
*/
filepos_t EbmlMaster::RenderData(IOCallback & output, bool bForceRender, ShouldWrite writeFilter)
filepos_t EbmlMaster::RenderData(IOCallback & output, bool bForceRender, const ShouldWrite & writeFilter)
{
filepos_t Result = 0;

Expand Down Expand Up @@ -97,7 +97,7 @@ bool EbmlMaster::PushElement(EbmlElement & element)
return false;
}

std::uint64_t EbmlMaster::UpdateSize(ShouldWrite writeFilter, bool bForceRender)
std::uint64_t EbmlMaster::UpdateSize(const ShouldWrite & writeFilter, bool bForceRender)
{
SetSize_(0);

Expand Down Expand Up @@ -126,7 +126,7 @@ std::uint64_t EbmlMaster::UpdateSize(ShouldWrite writeFilter, bool bForceRender)
return GetSize();
}

filepos_t EbmlMaster::WriteHead(IOCallback & output, int nSizeLength, ShouldWrite writeFilter)
filepos_t EbmlMaster::WriteHead(IOCallback & output, int nSizeLength, const ShouldWrite& writeFilter)
{
SetSizeLength(nSizeLength);
return RenderHead(output, false, writeFilter);
Expand Down
4 changes: 2 additions & 2 deletions src/EbmlSInteger.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ EbmlSInteger::operator std::int64_t() const {return GetValue();}
/*!
\todo handle exception on errors
*/
filepos_t EbmlSInteger::RenderData(IOCallback & output, bool /* bForceRender */, ShouldWrite /* writeFilter */)
filepos_t EbmlSInteger::RenderData(IOCallback & output, bool /* bForceRender */, const ShouldWrite & /* writeFilter */)
{
std::array<binary, 8> FinalData; // we don't handle more than 64 bits integers
unsigned int i;
Expand All @@ -67,7 +67,7 @@ filepos_t EbmlSInteger::RenderData(IOCallback & output, bool /* bForceRender */,
return GetSize();
}

std::uint64_t EbmlSInteger::UpdateSize(ShouldWrite writeFilter, bool /* bForceRender */)
std::uint64_t EbmlSInteger::UpdateSize(const ShouldWrite & writeFilter, bool /* bForceRender */)
{
if (!CanWrite(writeFilter))
return 0;
Expand Down
4 changes: 2 additions & 2 deletions src/EbmlString.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ EbmlString::EbmlString(const EbmlCallbacksDefault<const char *> & classInfo)
/*!
\todo handle exception on errors
*/
filepos_t EbmlString::RenderData(IOCallback & output, bool /* bForceRender */, ShouldWrite /* writeFilter */)
filepos_t EbmlString::RenderData(IOCallback & output, bool /* bForceRender */, const ShouldWrite & /* writeFilter */)
{
filepos_t Result;
output.writeFully(Value.c_str(), Value.length());
Expand All @@ -40,7 +40,7 @@ filepos_t EbmlString::RenderData(IOCallback & output, bool /* bForceRender */, S
return Result;
}

std::uint64_t EbmlString::UpdateSize(ShouldWrite writeFilter, bool /* bForceRender */)
std::uint64_t EbmlString::UpdateSize(const ShouldWrite & writeFilter, bool /* bForceRender */)
{
if (!CanWrite(writeFilter))
return 0;
Expand Down
4 changes: 2 additions & 2 deletions src/EbmlUInteger.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ EbmlUInteger::operator std::uint64_t() const {return GetValue();}
/*!
\todo handle exception on errors
*/
filepos_t EbmlUInteger::RenderData(IOCallback & output, bool /* bForceRender */, ShouldWrite /* writeFilter */)
filepos_t EbmlUInteger::RenderData(IOCallback & output, bool /* bForceRender */, const ShouldWrite & /* writeFilter */)
{
std::array<binary, 8> FinalData; // we don't handle more than 64 bits integers

Expand All @@ -49,7 +49,7 @@ filepos_t EbmlUInteger::RenderData(IOCallback & output, bool /* bForceRender */,
return GetSize();
}

std::uint64_t EbmlUInteger::UpdateSize(ShouldWrite writeFilter, bool /* bForceRender */)
std::uint64_t EbmlUInteger::UpdateSize(const ShouldWrite & writeFilter, bool /* bForceRender */)
{
if (!CanWrite(writeFilter))
return 0;
Expand Down
Loading
Loading