Remove NULLing of ssl context in TLS1.2 transform population #8384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-elliott-arm
added
needs-review
paul-elliott-arm
changed the title
3 tasks
Remove a piece of code that was meant to ensure non-usage of the ssl context under conditions where it should not be used, as this now makes less sense and also triggers coverity. Signed-off-by: Paul Elliott <paul.elliott@arm.com>
paul-elliott-arm
force-pushed
the
remove_ssl_null_tls12
branch
from
46d1413
to
4fb1955
Compare
gilles-peskine-arm
removed
needs-ci
tom-cosgrove-arm
approved these changes
Dec 21, 2023
tom-cosgrove-arm
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove a piece of code that was meant to ensure non-usage of the ssl context (by NULL-ing it) under conditions where it should not be used, as this now makes less sense and also triggers coverity.
Also remove redundant NULL check on the ssl contextt further down the function.
PR checklist
Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")
provided, ornot required (minor change to debug code), or not required[Backport 2.28] Remove NULLing of ssl context in TLS1.2 transform population #8386provided, ornot required - current tests will cover this.Have to admit I'm not entirely sure about backporting this one - its not a security fix, just a simplification. I have done the backport, but feel free to express views on this.