[Backport 2.28] Remove NULLing of ssl context in TLS1.2 transform population #8386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-elliott-arm
added
needs-review
3 tasks
Remove a piece of code that was meant to ensure non-usage of the ssl context (by NULL-ing it) under conditions where it should not be used, as this now makes less sense. Signed-off-by: Paul Elliott <paul.elliott@arm.com>
paul-elliott-arm
force-pushed
the
remove_ssl_null_tls12_2_28
branch
from
b89b338
to
9c2faca
Compare
| @@ -1004,8 +1004,7 @@ static int ssl_populate_transform(mbedtls_ssl_transform *transform, | |||
| !defined(MBEDTLS_SSL_EXPORT_KEYS) && \ | |||
| !defined(MBEDTLS_SSL_DTLS_CONNECTION_ID) && \ | |||
| !defined(MBEDTLS_DEBUG_C) | |||
| ssl = NULL; /* make sure we don't use it except for those cases */ | |||
| (void) ssl; | |||
| (void) ssl; /* ssl is unused except for those cases */ | |||
There was a problem hiding this comment.
Could we actually use the compiler to help us do this? With this after the (void) ssl?
#define ssl ssl_argument_must_not_be_accessed
There was a problem hiding this comment.
It's not really important that the function doesn't use ssl for other purposes. KISS.
tom-cosgrove-arm
approved these changes
Dec 15, 2023
tom-cosgrove-arm
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove a piece of code that was meant to ensure non-usage of the ssl context (by NULL-ing it) under conditions where it should not be used, as this now makes less sense. Backport of #8384
PR checklist
Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")
Notes for the submitter
Please refer to the contributing guidelines, especially the
checklist for PR contributors.