-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Related links #1054
base: dev/new_features
Are you sure you want to change the base?
Related links #1054
Conversation
Limit it to links would be fine for me, but I don't think that it makes sense 🤔 |
@@ -894,4 +897,14 @@ public function canUpdateUser(User $actor): bool | |||
return $this->apDomain === $actor->apDomain; | |||
} | |||
} | |||
|
|||
public function getRelatedLinks(): array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add phpDoc so we know which kind of array is returned? I really liked if the returned value would be of RelatedLink[]
so an array of objects, so we can add some validation logic so we can mark links as "checked" or something so we know that the rel=me is actually correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed Discussed on element chat.
I don't know a elegant way to denormalize the json field from table and return it on get method. This'll required some dependencies inside entity that I think is not a good practice.
Instead, I created a RelatedLinkDTO class and this will be returned in UserDTO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd love if the add button would something like this (but that is not a requirement):
I noticed that the links are not yet displayed on the profile page. Are you planning on adding that in this PR?
(The activity pub representation of the fields is also missing, but I expected to do that myself anyways :) but if you'd like to try that as well, feel free to do so)
Oh and please change the target of the PR to |
edc97fa
to
481b0f7
Compare
ffbdc54
to
98ed7e1
Compare
Added new dynamic field in profile section witch let us to add related links.
could you rebase your branch on |
Also there is file conflicts xd again? Sorry about that. |
d07c5c3
to
fa6f302
Compare
Co-authored-by: Melroy van den Berg <melroy@melroy.org>
fa6f302
to
09a90b4
Compare
Fixed merge conflicts.. |
Revisit the latest code changes
Fix the php-cs-fixer |
PR should be ready for last review now.. I hope. 🥳 |
cf72318
to
7cd555b
Compare
Co-authored-by: Melroy van den Berg <melroy@melroy.org>
ed923ae
to
9b44612
Compare
@JaviviJR did you push all your changes? The modifications of the edit profile page and the user box are not there, yet |
e05d4f2
to
6bae56c
Compare
Added new dynamic field in profile section witch let us to add related links.
#839