Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta: Maximizing, then unmaximizing the window doesn't revert the window back to its unmaximized state #197

Closed
Gold856 opened this issue Sep 26, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Gold856
Copy link

Gold856 commented Sep 26, 2024

Describe the bug
When AdvantageScope is first started, it has a translucent background and rounded corners. These disappear when the window is maximized, but when the window is unmaximized, the window does not regain the translucent background and rounded corners.

To Reproduce
Steps to reproduce the behavior:

  1. Open AdvantageScope.
  2. Maximize the window.
  3. Unmaximize the window.
  4. Notice the lack of rounded corners and translucent background.

Expected behavior
I expected the rounded corners and translucency to return.

Screenshots
image

Version (required):
Version: 4.0.0-beta-1
Distributor: WPILib
Platform: win32-x64
Build Date: 9/26/2024, 24:43:48 UTC
Electron: 32.0.2
Chromium: 128.0.6613.84
Node: 20.16.0

@Gold856 Gold856 added the bug Something isn't working label Sep 26, 2024
@jwbonner
Copy link
Member

It looks like both this issue and #198 are related to electron/electron#41824. I'll need to do some experimentation to see if there's a way to work around the issue.

@jwbonner
Copy link
Member

jwbonner commented Oct 5, 2024

I've tried a couple of approaches, but unfortunately I can't find an effective workaround for that Electron bug. The only options would be to disable maximization (a regression from the 2024 version) or disable the new background material. I've gone with the latter option, and I'll monitor the Electron issue to see if we can eventually bring back the improved design.

The new title bar and menu bar are still enabled, since they don't appear to be causing any issues on their own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants