-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Site Layout Editor - Meeds-io/MIPs#175 #1048
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will allow to store a Portal Site of type Draft in order to allow drafting the layout changes.
…eeds-io/MIPs#175 (#1037) This change will allow to retrieve Draft Site content using WebUI context.
…s#175 This change will allow to map properties from database for Page Body.
…MEED-8281 - Meeds-io/MIPs#175 (#1041) This change will allow to centralize the system apps and divs to be served by `UIPortalApplication` rather than Addon Containers added inside the `sharedlayout.xml` and `portal.xml` of standalone sites.
…/MIPs#175 (#1042) This change will allow to render an application only without having to render the whole `UIPortalApplication` each time a single application is requested.
…eeds-io/MIPs#175 Prior to this change, the Topbar wasn't elevated when the site body is scrolled. This change ensures to apply the adequate Class Helper in order to make it elevated once the site body is scrolled.
…EED-8266 - Meeds-io/MIPs#175 (#1044) Prior to this change, the Meta Site pages wasn't all time displaying the Shared layout. This change ensures to display the shared layout for Meta Site Pages even when site is made as not displayed.
…IPs#175 Due to recent changes, the WebUI Portlets has been deprecated and the WebUI general components has become stateless and relies from now on on a transient state stored in PortalRequestContext object only which is managed by Current HTTP Request only (linked to HTTPRequest Lifecycle, built on Request Start and destroyed just after). Thus, the WebUI components Tree can become statically built for all users independently from its ACL. The static WebUI Tree Feature has to be enabled by default and can be disabled by feature flag portal.staticWebUIComponents. Its default value will be set to true for Meeds and set to false for other distributions until the WebUI Portlets Deprecation is considered in other packages based on Meeds Distribution.
… - Meeds-io/MIPs#175 (#1047) Prior to this change, the CSS Classes of Margins in Site Layout Sections was computed as it was an application Margin. This change will ensure to differentiate Section Margins computing from Applications Margin Computing.
…1056) Prior to this change, the Portlets specific JS in HTTP Headers wasn't included since the 'jsManager' Tag is built before building the Portlets content. This change will ensure to build the Portlet Header Markup and JS dependencies before retrieving the JS Content.
boubaker
force-pushed
the
merge-mip-175
branch
from
February 6, 2025 03:28
58f54e6
to
dd4dcfe
Compare
This change will delete rendering of JSManager Tag when a single Portlet Application is requested to be displayed.
…eeds-io/MIPs#175 Prior to this change, the 'body-end-container' addons container has been moved from sharedlayout and pages to be included inside the UIPortalApplication directly which leads to not include JS & CSS of referenced applications automatically. This change will statically include those resources to ensure that those resources are properly loaded in all pages.
Quality Gate failedFailed conditions |
AzmiTouil
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Meeds-io/MIPs#175