Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AS conversion fixes #3970

Merged
merged 1 commit into from
Nov 11, 2022
Merged

AS conversion fixes #3970

merged 1 commit into from
Nov 11, 2022

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Nov 9, 2022

Some more conversion fixes. See #3961

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 23.06% // Head: 23.06% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (5939096) compared to base (ef392e3).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #3970      +/-   ##
============================================
- Coverage     23.06%   23.06%   -0.01%     
  Complexity     4813     4813              
============================================
  Files          2263     2263              
  Lines        248350   248366      +16     
  Branches      46164    46171       +7     
============================================
- Hits          57279    57278       -1     
- Misses       189612   189629      +17     
  Partials       1459     1459
Impacted Files Coverage Δ
...mmon/alphaStrike/conversion/ASDamageConverter.java 0.00% <0.00%> (ø)
...trike/conversion/ASMekSpecialAbilityConverter.java 0.00% <0.00%> (ø)
...on/alphaStrike/conversion/ASMovementConverter.java 0.00% <0.00%> (ø)
...haStrike/conversion/ASSpecialAbilityConverter.java 0.00% <0.00%> (ø)
...e/conversion/ASVehicleSpecialAbilityConverter.java 0.00% <0.00%> (ø)
.../weapons/battlearmor/ISBAGrenadeLauncherMicro.java 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

NickAragua
NickAragua approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@NickAragua NickAragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@HammerGS HammerGS merged commit 15ec8f3 into MegaMek:master Nov 11, 2022
HammerGS added a commit that referenced this pull request Nov 11, 2022
@HammerGS
+ PR #3970 - AS conversion fixes
cf93332 
+ PR #3971 - Implements #3747 add option to adjust the seen by in the
unit tool tip
+ PR #3972 = AS conversion fixes round 2
@HammerGS HammerGS mentioned this pull request Nov 11, 2022
Open
43 tasks
@SJuliez SJuliez deleted the AS_fixes branch January 6, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickAragua NickAragua NickAragua approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SJuliez @NickAragua @HammerGS