Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field Gun CI Alpha Strike changes #4067

Merged
merged 3 commits into from
Dec 26, 2022
Merged

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Dec 24, 2022

AS conversion from #3961 (future errata): Field Gun CI use Field Gun Damage only instead of standard CI damage and may get AC and FLK

@codecov
Copy link

codecov bot commented Dec 24, 2022

Codecov Report

Base: 23.02% // Head: 23.02% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (bbf870a) compared to base (790eb55).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4067      +/-   ##
============================================
- Coverage     23.02%   23.02%   -0.01%     
  Complexity     4816     4816              
============================================
  Files          2275     2275              
  Lines        249513   249519       +6     
  Branches      46283    46283              
============================================
  Hits          57443    57443              
- Misses       190618   190624       +6     
  Partials       1452     1452              
Impacted Files Coverage Δ
...rike/conversion/ASConvInfantryDamageConverter.java 0.00% <0.00%> (ø)
...ommon/alphaStrike/conversion/ASLocationMapper.java 0.00% <0.00%> (ø)
...gamek/src/megamek/client/ratgenerator/Ruleset.java 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@Windchild292 Windchild292 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things first

@SJuliez SJuliez merged commit 9b53ca4 into MegaMek:master Dec 26, 2022
@SJuliez SJuliez deleted the AS_Corrections_2 branch January 6, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants