Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AS Conversion: BA with jump MP reduced to 0 count as non-jumping #4113

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Jan 15, 2023

DWP/ DMP can reduce jump MP to 0 which should make them list "f" (foot) as their movement type.

Raised in #3961

@codecov
Copy link

codecov bot commented Jan 15, 2023

Codecov Report

Base: 22.95% // Head: 22.95% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (56eed57) compared to base (7736c49).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4113      +/-   ##
============================================
- Coverage     22.95%   22.95%   -0.01%     
  Complexity     4817     4817              
============================================
  Files          2282     2282              
  Lines        250311   250315       +4     
  Branches      46367    46368       +1     
============================================
  Hits          57462    57462              
- Misses       191398   191402       +4     
  Partials       1451     1451              
Impacted Files Coverage Δ
...on/alphaStrike/conversion/ASMovementConverter.java 0.00% <0.00%> (ø)
...gamek/src/megamek/client/ratgenerator/Ruleset.java 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Windchild292 Windchild292 merged commit 342064e into MegaMek:master Jan 16, 2023
@SJuliez SJuliez deleted the ASConversion_BA_Jump branch January 16, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants