Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn sounds #4151

Merged
merged 10 commits into from
Feb 15, 2023
Merged

turn sounds #4151

merged 10 commits into from
Feb 15, 2023

Conversation

kuronekochomusuke
Copy link
Collaborator

@kuronekochomusuke kuronekochomusuke commented Feb 2, 2023

turn sounds
Fixes #4126

  • add option to play a sound when it is my turn
  • add option to play a sound when it is others turn
  • add option to set sound file for chat, my turn, and others turn

image

Copy link
Contributor

@Windchild292 Windchild292 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things first

megamek/src/megamek/client/ui/swing/ClientGUI.java Outdated Show resolved Hide resolved
megamek/src/megamek/client/ui/swing/ClientGUI.java Outdated Show resolved Hide resolved
megamek/src/megamek/client/ui/swing/ClientGUI.java Outdated Show resolved Hide resolved
megamek/src/megamek/client/ui/swing/ClientGUI.java Outdated Show resolved Hide resolved
megamek/src/megamek/client/ui/swing/ClientGUI.java Outdated Show resolved Hide resolved
megamek/src/megamek/client/ui/swing/ClientGUI.java Outdated Show resolved Hide resolved
megamek/src/megamek/client/ui/swing/ClientGUI.java Outdated Show resolved Hide resolved
megamek/src/megamek/client/ui/swing/GUIPreferences.java Outdated Show resolved Hide resolved
megamek/src/megamek/client/ui/swing/GUIPreferences.java Outdated Show resolved Hide resolved
megamek/src/megamek/client/ui/swing/GUIPreferences.java Outdated Show resolved Hide resolved
kuronekochomusuke and others added 6 commits February 4, 2023 12:20
Co-authored-by: Justin Bowen <39067288+Windchild292@users.noreply.github.com>
Co-authored-by: Justin Bowen <39067288+Windchild292@users.noreply.github.com>
Co-authored-by: Justin Bowen <39067288+Windchild292@users.noreply.github.com>
Co-authored-by: Justin Bowen <39067288+Windchild292@users.noreply.github.com>
Co-authored-by: Justin Bowen <39067288+Windchild292@users.noreply.github.com>
Co-authored-by: Justin Bowen <39067288+Windchild292@users.noreply.github.com>
@HammerGS
Copy link
Member

HammerGS commented Feb 4, 2023

The return of the bong!

Does this allow a player to send a sound if needed or is it strictly linked to phase. Also can you set different sounds for each?

@Windchild292
Copy link
Contributor

Separate files can be specified, and it is strictly linked to the client's changes.

@HammerGS
Copy link
Member

HammerGS commented Feb 7, 2023

This now has merge conflicts and looks like the requested changes are in.

@SJuliez SJuliez merged commit 3ec34ed into MegaMek:master Feb 15, 2023
@kuronekochomusuke kuronekochomusuke deleted the turnSounds branch March 3, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFE] option to play sound for change of active player within phase
4 participants