Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AS Conversion and Cards #4278

Merged
merged 4 commits into from
Apr 2, 2023
Merged

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Mar 30, 2023

see #3961

  • Corrects the slightly different background colors used on the cards
  • IS ER Proto LL now uses 15 heat for AS
  • BA with Artillery tubes now receive ARTBA
  • Allows armor pip wrapping for high armor values for aeros and improves the armor pip arrangement when wrapping

Changes are per commit

@SJuliez SJuliez changed the title AS Conversion AS Conversion and Cards Mar 30, 2023
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage: 5.26% and no project coverage change.

Comparison is base (586dde7) 22.51% compared to head (ef15d2d) 22.51%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4278   +/-   ##
=========================================
  Coverage     22.51%   22.51%           
  Complexity     4818     4818           
=========================================
  Files          2299     2299           
  Lines        255232   255218   -14     
  Branches      47026    47025    -1     
=========================================
  Hits          57454    57454           
+ Misses       196327   196313   -14     
  Partials       1451     1451           
Impacted Files Coverage Δ
...egamek/src/megamek/common/EquipmentTypeLookup.java 0.00% <ø> (ø)
...amek/common/alphaStrike/cardDrawer/ASAeroCard.java 0.00% <0.00%> (ø)
.../megamek/common/alphaStrike/cardDrawer/ASCard.java 0.00% <0.00%> (ø)
...mon/alphaStrike/cardDrawer/ASHeatTrackingCard.java 0.00% <0.00%> (ø)
...common/alphaStrike/cardDrawer/ASLargeAeroCard.java 0.00% <0.00%> (ø)
...gamek/common/alphaStrike/cardDrawer/ASMekCard.java 0.00% <0.00%> (ø)
...mmon/alphaStrike/conversion/ASDamageConverter.java 0.00% <0.00%> (ø)
...on/weapons/prototypes/ISERLaserLargePrototype.java 78.72% <0.00%> (ø)
.../common/weapons/battlearmor/ISBATubeArtillery.java 78.94% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HammerGS
Copy link
Member

Pulled the branch and tested and everything looks good to me.

@SJuliez SJuliez merged commit a6f7f21 into MegaMek:master Apr 2, 2023
@SJuliez SJuliez deleted the AS_Conversion_290323 branch June 28, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants