add deployment options #4922

kuronekochomusuke · 2023-11-24T16:39:05Z

add option to default Non-bot players to team 1
add option for Non-bot player entities with "Use Owners*" deployment set, use Player 0's settings, instead of current player's settings
these should help speed up lobby setup in coop games.
defaulted them to off, to have the current behavior.

allow limiting the "Any" deployment zone to an arbitrary smaller square area
must turn off exclusive double blind deployment zones
can select the NW and SE corners of the square in player and entity configs
setting to (0, 0) - (0, 0) disables the limit and can deploy anywhere as normal

show player deployments on map preview
add refresh preview button to update player deployments on map preview. to make it easier to adjust the deployment positions, while keeping the map preview open
add ruler to map preview

to use ruler to set Deployment Any corners:

select start and end points with ruler on map preview
hit "Use ruler coords" in player config
hit "Apply" or "Ok" button in player config
hit "refresh preview" button on map preview to show updated deployment zone

if blind drop hide enemy player deployment zones from non gm players
allow gm to see and edit all units on any team, hidden or not, in lobby
while in lobby and there is a gm, if player disconnects transfer the disconnected player's units to the gm

set to a single hex

megamek/src/megamek/server/Server.java

HammerGS · 2023-11-24T18:10:17Z

This sounds like a huge help for games like Joker runs.

megamek/src/megamek/client/ui/swing/lobby/PlayerSettingsDialog.java

…disconnected players unit to gm

SJuliez

I'd appreciate if the texts could be adjusted but otherwise good to go. I wonder if we might once upgrade deployment to a class that supports various forms of deployment areas. This might lighten the load of specialized code such as the one in here for Entity, PlayerSettings and other classes and offer more variety of deployment. I once went through some of the Chaos Campaign books and noted all deployment variations. Quite a lot of different area types. Also, it could be interesting to have deployment options that can be programmed in MHQ but are difficult to represent in a GUI.

SJuliez · 2023-12-19T22:24:05Z

megamek/i18n/megamek/client/messages.properties

@@ -285,6 +285,7 @@ BoardSelectionDialog.UpdateSize=Update Size
 BoardSelectionDialog.Updating=Updating...
 BoardSelectionDialog.ViewGameBoard=Preview Game Map... *
 BoardSelectionDialog.ViewGameBoardTooltip=Shows a preview of the game's map.<br> * Note: For generated maps and surprise maps the preview is only a sample<br> and will not be the same as the actual map used.
+BoardSelectionDialog.ViewGameBoardButton=refresh preview


Since this is a button text I feel this needs at least a capital letter as the first

SJuliez · 2023-12-19T22:24:23Z

megamek/i18n/megamek/client/messages.properties

+CustomMechDialog.labDeploymentAnyNW=Deployment Any NW corner:
+CustomMechDialog.labDeploymentAnySE=Deployment Any SE corner:
+CustomMechDialog.BtnDeploymentUseRuler=Use ruler coords
+CustomMechDialog.BtnDeploymentUseRulerTip=set the Any NW and SE corners based on the corners of the NW and SE corners the square defined by the map preview ruler  


Capital letter

SJuliez · 2023-12-19T22:25:34Z

megamek/i18n/megamek/common/options/messages.properties

@@ -33,6 +33,10 @@ GameOptionsInfo.option.dumping_from_round.displayableName=first round for ammo d
 GameOptionsInfo.option.dumping_from_round.description=Number of the round that has to be at least reached before allowing ammo dumps.
 GameOptionsInfo.option.set_arty_player_homeedge.displayableName=Automatically set artillery home edge
 GameOptionsInfo.option.set_arty_player_homeedge.description=If checked, all of the players' artillery units will have their home edge set to the deployment edge of the player, NW and NE are North, SW and SE are South. \nUnchecked by default.
+GameOptionsInfo.option.set_default_team_1.displayableName=Default non-bot players to team 1
+GameOptionsInfo.option.set_default_team_1.description=Unchecked each player is assigned new team


I feel this is not understandable unless you already know what it does. At least it should start with "When this option is unchecked, "

SJuliez · 2023-12-19T22:25:56Z

megamek/i18n/megamek/common/options/messages.properties

+GameOptionsInfo.option.set_default_team_1.displayableName=Default non-bot players to team 1
+GameOptionsInfo.option.set_default_team_1.description=Unchecked each player is assigned new team
+GameOptionsInfo.option.set_player_deployment_to_player0.displayableName=Non-bot player entities with \"Use Owners*\" deployment set, use Player 0\'s settings, instead of current player\'s settings
+GameOptionsInfo.option.set_player_deployment_to_player0.description=Unchecked use current player deployments settings


sldfgunslinger2766 · 2023-12-19T22:49:10Z

As per Julie's comment on the Chaos Campaign deployment types: being able to deploy on more than one 'edge/side' would be really useful and cool...

+ PR #4957: More tooltips colors (set FG color and BG color for more tooltips, add highlight, weapon, quirk client settings, consolidate some colors into existing client setting colors) + PR #4922: Add deployment options (There is a lot in this one see note from PR link for specifics)

kuronekochomusuke added 2 commits November 24, 2023 11:27

add team and player0 deployemnt options

a560f8c

typo

9640b11

github-advanced-security bot found potential problems Nov 24, 2023

View reviewed changes

megamek/src/megamek/server/Server.java Fixed Show fixed Hide fixed

kuronekochomusuke added the GUI User Interface label Nov 24, 2023

kuronekochomusuke marked this pull request as draft November 24, 2023 16:45

code cleanup

2d419e1

kuronekochomusuke added 2 commits November 24, 2023 13:29

handle overlapping start positions and player display

c4cd96c

allow limiting Any deployment to a smaller square area

cf4f166

github-advanced-security bot found potential problems Nov 24, 2023

View reviewed changes

megamek/src/megamek/client/ui/swing/lobby/PlayerSettingsDialog.java Fixed Show fixed Hide fixed

megamek/src/megamek/client/ui/swing/lobby/PlayerSettingsDialog.java Fixed Show fixed Hide fixed

kuronekochomusuke added 5 commits November 24, 2023 18:31

code cleanup

688dc50

show player deployments on map preview

11a8d30

if blind drop hid player deployment zones from non gm player

ec89204

code cleanup

262b730

allow gm to see and edit all units on any team hidden or not in lobby

b3150d6

kuronekochomusuke added the GM Tools All things related to the GM Tools project. label Nov 25, 2023

kuronekochomusuke added 13 commits November 25, 2023 13:26

correct issue

1cfebff

save and load from mul

86a483f

add ruler to map preview

9195c91

insure ruler is always on top of the map preview

a106899

apply ruler coords for deployment Any corners

ab56dc6

update button to apply any deployment changes

966f32d

correct issue

5163750

update message

65cf65d

use 2 buttons

c2fe464

correct gm edit issue

3c6518d

while in lobby and there is a gm, if player disconnects transfer the …

1fad826

…disconnected players unit to gm

code cleanup

c913302

code cleanup

6df8b2f

kuronekochomusuke marked this pull request as ready for review December 5, 2023 00:33

SJuliez requested changes Dec 19, 2023

View reviewed changes

text cleanup

a1efa21

SJuliez approved these changes Dec 20, 2023

View reviewed changes

HammerGS merged commit 06b637e into MegaMek:master Dec 21, 2023
5 checks passed

kuronekochomusuke deleted the deploymentOptions branch December 31, 2023 21:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add deployment options #4922

add deployment options #4922

kuronekochomusuke commented Nov 24, 2023 •

edited

Loading

HammerGS commented Nov 24, 2023

SJuliez left a comment

SJuliez Dec 19, 2023

SJuliez Dec 19, 2023

SJuliez Dec 19, 2023

SJuliez Dec 19, 2023

sldfgunslinger2766 commented Dec 19, 2023

add deployment options #4922

add deployment options #4922

Conversation

kuronekochomusuke commented Nov 24, 2023 • edited Loading

HammerGS commented Nov 24, 2023

SJuliez left a comment

Choose a reason for hiding this comment

SJuliez Dec 19, 2023

Choose a reason for hiding this comment

SJuliez Dec 19, 2023

Choose a reason for hiding this comment

SJuliez Dec 19, 2023

Choose a reason for hiding this comment

SJuliez Dec 19, 2023

Choose a reason for hiding this comment

sldfgunslinger2766 commented Dec 19, 2023

kuronekochomusuke commented Nov 24, 2023 •

edited

Loading