Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of protomech ammo ammounts #5231

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Conversation

neoancient
Copy link
Member

Since protomech ammo is per-shot, the number of shots is in parentheses at the end of the equipment line in the block file. When looking for the line it checks for the first parenthesis rather than the last one, which causes an error with ammo types that include the munition type in parentheses in the name.

Fixes MegaMek/megameklab#1304

@SJuliez SJuliez merged commit 95653ac into master Mar 9, 2024
4 checks passed
@SJuliez SJuliez deleted the proto_load_alt_munitions branch April 20, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple Missile Ammunition Types in Protomechs
3 participants