Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement #4397 Internal Bomb Bay (MHQ compatibility) #3805

Merged

Conversation

Sleet01
Copy link
Collaborator

@Sleet01 Sleet01 commented Dec 29, 2023

This PR must be taken into MHQ after MegaMek PR #4974 is pulled.

Changes:

  • fixes a unit test that fails once AeroSpaceFighter class is introduced.
  • Makes clearGameData (called after MM games return to MHQ) aware of Internal and External bomb stores.
  • Add handling for internal bombs in XML writer.
  • Misc. commenting around bomb panel code explaining changes.

Testing:

  • Added, changed, removed bombs from various Aerospace units with and without Internal Bomb Bay quirk.
  • Ran all unit tests.

Note: tests for this PR will fail until MegaMek PR #4974 #5003 is pulled.

@SJuliez SJuliez merged commit edc25a6 into MegaMek:master Jan 3, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants