fix: Use .mappings() in cursor, to get rows as mappings
#309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarrmondragon
changed the title
._mapping attribute to get row dictionary.mapping().all() to get rows as mappings
edgarrmondragon
changed the title
.mapping().all() to get rows as mappings.mapping().all() in cursor, to get rows as mappings
edgarrmondragon
changed the title
.mapping().all() in cursor, to get rows as mappings.mapping() in cursor, to get rows as mappings
edgarrmondragon
changed the title
.mapping() in cursor, to get rows as mappings.mappings() in cursor, to get rows as mappings
|
Good stuff @edgarrmondragon :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was fixed upstream in meltano/sdk#1487, but this tap overridesget_records.I think meltano/sdk#2094 is the only difference between the two implementations?
UPDATE: Using the private
._mappingattribute makes me nervous so I opened meltano/sdk#2095 and updated this PR.