fix: Address SQLAlchemy 2.0 deprecation warnings #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarrmondragon
force-pushed
the
feat/support-sqlalchemy-2
branch
from
73c65e3 to
6c9ccbb
Compare
edgarrmondragon
changed the title
edgarrmondragon
requested review from
cjohnhanson and
aaronsteers
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1487 +/- ##
==========================================
+ Coverage 85.44% 85.50% +0.05%
==========================================
Files 57 57
Lines 4756 4760 +4
Branches 809 813 +4
==========================================
+ Hits 4064 4070 +6
+ Misses 500 498 -2
Partials 192 192
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
WillDaSilva
approved these changes
Mar 6, 2023
edgarrmondragon
force-pushed
the
feat/support-sqlalchemy-2
branch
from
b96f641 to
d718c42
Compare
edgarrmondragon
added a commit
to MeltanoLabs/tap-postgres
that referenced
this pull request
Dec 12, 2023
~This was fixed upstream in meltano/sdk#1487, but this tap overrides `get_records`.~ I think meltano/sdk#2094 is the only difference between the two implementations? UPDATE: Using the private `._mapping` attribute makes me nervous so I opened meltano/sdk#2095 and updated this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't yet add support for SQLAlchemy 2.0 (#1484), since downstream SQL taps and targets may need to either pin the SDK or set an upper limit for SQLAlchemy.
https://docs.sqlalchemy.org/en/20/changelog/migration_20.html
📚 Documentation preview 📚: https://meltano-sdk--1487.org.readthedocs.build/en/1487/