Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ongoing fix #44

Merged
merged 1 commit into from
Oct 13, 2022
Merged

ongoing fix #44

merged 1 commit into from
Oct 13, 2022

Conversation

LittleBeannie
Copy link
Collaborator

fix eAccural

@LittleBeannie LittleBeannie linked an issue Oct 13, 2022 that may be closed by this pull request
gs_spending_bound bug when IA is close to FA #40
Closed
@nanxstats nanxstats merged commit f6cb25c into main Oct 13, 2022
@nanxstats
Copy link
Collaborator

I'm merging this because looks like it's urgent. Please do fix any issues this causes later.

@nanxstats nanxstats deleted the 40-gs_spending_bound-bug-when-ia-is-close-to-fa branch October 13, 2022 16:17
@nanxstats
Copy link
Collaborator

Since this would introduce an additional hard dependency, is purrr::reduce() really necessary here? Maybe base::Reduce is good enough?

@LittleBeannie LittleBeannie restored the 40-gs_spending_bound-bug-when-ia-is-close-to-fa branch October 13, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanxstats nanxstats Awaiting requested review from nanxstats

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gs_spending_bound bug when IA is close to FA
2 participants
@LittleBeannie @nanxstats