Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Remove deprecated function and improve error handling #224

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

ValentinBuira
Copy link
Contributor

This PR contain two cleanup

Needed to cleanup in the plugin PR MerginMaps/qgis-plugin#650

* Use ClientError syntax for "workspace_service"
Copy link
Contributor

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe enough time passed already and it is safe to remove this one 👍🏻

mergin/client.py Outdated Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12141436766

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 79.289%

Changes Missing Coverage Covered Lines Changed/Added Lines %
mergin/client.py 0 2 0.0%
Totals Coverage Status
Change from base Build 12068081183: 0.2%
Covered Lines: 3258
Relevant Lines: 4109

💛 - Coveralls

@MarcelGeo MarcelGeo merged commit 8716eec into master Dec 5, 2024
4 checks passed
@MarcelGeo MarcelGeo deleted the cleanup-client-service branch December 5, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants