Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup useless function and error handling #650

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Cleanup useless function and error handling #650

merged 1 commit into from
Dec 6, 2024

Conversation

ValentinBuira
Copy link
Contributor

@ValentinBuira ValentinBuira commented Dec 3, 2024 •
edited
Loading

This PR contain two cleanup

Rely on MerginMaps/python-api-client#224

@ValentinBuira
* Remove useless "post_login" and "mc.user_service()"
089cda5 
* Handle new ClientError from "mc.workspace_service"
@ValentinBuira ValentinBuira mentioned this pull request Dec 3, 2024
Merged
tomasMizera
tomasMizera approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ValentinBuira ValentinBuira added dependencies Pull requests that update a dependency file requires dependency release Other dependencies must be released before this one and removed dependencies Pull requests that update a dependency file labels Dec 3, 2024
@ValentinBuira ValentinBuira merged commit d75fa88 into master Dec 6, 2024
7 checks passed
@ValentinBuira ValentinBuira deleted the cleanup-service-handling branch December 6, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasMizera tomasMizera tomasMizera approved these changes

@varmar05 varmar05 Awaiting requested review from varmar05

Assignees
No one assigned
Labels
requires dependency release Other dependencies must be released before this one
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ValentinBuira @tomasMizera