Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyring.signTypedData does not support V1 #225

Closed
mikesposito opened this issue Feb 21, 2025 · 0 comments · Fixed by #224
Closed

Keyring.signTypedData does not support V1 #225

mikesposito opened this issue Feb 21, 2025 · 0 comments · Fixed by #224

Comments

@mikesposito
Copy link
Member

The signTypedData method on the Keyring type has Record<string, unknown> as type for the data accepted. However, this means that the TypedDataV1` type for V1 is not supported.

As HDKeyring and SimpleKeyring support it, we should make the keyring method type wider
@mikesposito mikesposito mentioned this issue Feb 21, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Mar 19, 2025
@mikesposito @ccharly
fix!: Keyring.signTypedData accepts types for V1 (#224)
27a1e7e 
<!--
Thanks for your contribution! Take a moment to answer these questions so
that reviewers have the information they need to properly understand
your changes:

* What is the current state of things and why does it need to change?
* What is the solution your changes offer and how does it work?

Are there any issues or other links reviewers should consult to
understand this pull request better? For instance:

* Fixes #12345
* See: #67890
-->
* Fixes #225

## Examples

<!--
Are there any examples of this change being used in another repository?

When considering changes to the MetaMask module template, it's strongly
preferred that the change be experimented with in another repository
first. This gives reviewers a better sense of how the change works,
making it less likely the change will need to be reverted or adjusted
later.
-->

---------

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix!: Keyring.signTypedData accepts types for V1 MetaMask/accounts
1 participant
@mikesposito