Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: Keyring.signTypedData accepts types for V1 #224

Merged
merged 19 commits into from
Mar 19, 2025
Merged

fix!: Keyring.signTypedData accepts types for V1 #224

merged 19 commits into from
Mar 19, 2025

Conversation

mikesposito
Copy link
Member

@mikesposito mikesposito commented Feb 21, 2025 •
edited
Loading

@mikesposito mikesposito force-pushed the mikesposito/keyring-typed-message-type branch from 17b68dc to fc6bec1 Compare February 21, 2025 14:48
@mikesposito
Copy link
Member Author

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link

Preview builds have been published. See these instructions (from the core monorepo) for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/keyring-api": "17.1.0-5f85942",
  "@metamask-previews/eth-hd-keyring": "10.0.1-5f85942",
  "@metamask-previews/eth-ledger-bridge-keyring": "8.0.5-5f85942",
  "@metamask-previews/eth-simple-keyring": "8.1.1-5f85942",
  "@metamask-previews/eth-trezor-keyring": "6.1.1-5f85942",
  "@metamask-previews/keyring-internal-api": "4.0.2-5f85942",
  "@metamask-previews/keyring-internal-snap-client": "4.0.0-5f85942",
  "@metamask-previews/eth-snap-keyring": "11.0.0-5f85942",
  "@metamask-previews/keyring-snap-client": "4.0.0-5f85942",
  "@metamask-previews/keyring-snap-sdk": "3.0.0-5f85942",
  "@metamask-previews/keyring-utils": "2.2.0-5f85942"
}

@mikesposito mikesposito marked this pull request as ready for review February 21, 2025 17:44
@mikesposito mikesposito requested a review from a team as a code owner February 21, 2025 17:44
@mikesposito mikesposito changed the title fix: Keyring.signTypedData accepts types for V1 fix!: Keyring.signTypedData accepts types for V1 Feb 21, 2025
ccharly
ccharly reviewed Feb 25, 2025
View reviewed changes
mikesposito and others added 2 commits February 25, 2025 15:56
@mikesposito @ccharly
Update packages/keyring-eth-hd/CHANGELOG.md
467a576 
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
@mikesposito @ccharly
Update packages/keyring-eth-simple/CHANGELOG.md
463d850 
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
@mikesposito mikesposito mentioned this pull request Feb 26, 2025
Closed
@mikesposito mikesposito force-pushed the mikesposito/keyring-typed-message-type branch from 3dfa946 to 94360d0 Compare March 19, 2025 09:17
ccharly
ccharly previously approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@ccharly ccharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion to fix the changelog, but we can also fix it later when doing a release!

@mikesposito @ccharly
Update packages/keyring-eth-ledger-bridge/CHANGELOG.md
8b332a6 
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
@mikesposito mikesposito enabled auto-merge March 19, 2025 10:40
@mikesposito mikesposito added this pull request to the merge queue Mar 19, 2025
Merged via the queue into main with commit 27a1e7e Mar 19, 2025
31 checks passed
@mikesposito mikesposito deleted the mikesposito/keyring-typed-message-type branch March 19, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccharly ccharly ccharly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keyring.signTypedData does not support V1
2 participants
@mikesposito @ccharly