Add signEIP7702Authorization and corresponding tests to hd and simple Eth keyrings #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffsmale90
force-pushed
the
feat/sign-authorization
branch
3 times, most recently
from
fbef2bf to
1e79c7f
Compare
jeffsmale90
changed the title
…imple. Fix corresponding tests in keyring-eth-hd.
jeffsmale90
force-pushed
the
feat/sign-authorization
branch
from
1e79c7f to
d34295d
Compare
danroc
reviewed
Feb 4, 2025
danroc
reviewed
Feb 4, 2025
danroc
reviewed
Feb 4, 2025
danroc
reviewed
Feb 4, 2025
danroc
reviewed
Feb 4, 2025
danroc
reviewed
Feb 4, 2025
danroc
reviewed
Feb 4, 2025
danroc
reviewed
Feb 4, 2025
danroc
reviewed
Feb 4, 2025
danroc
reviewed
Feb 4, 2025
danroc
reviewed
Feb 4, 2025
|
I left a few minor comments regarding the naming of some methods. From the perspective of this PR, it LGTM. I did raise some small concerns about |
…ce. Improve names of a few tests. Co-authored-by: Daniel Rocha <68558152+danroc@users.noreply.github.com>
- prefer .toStrictEqual in signEip7702Authorization test - use type imports where possible
danroc
approved these changes
Feb 5, 2025
|
@metamaskbot publish-previews |
ccharly
added a commit
to MetaMask/utils
that referenced
this pull request
Feb 11, 2025
#231) EIP-7702 defines a new struct Authorization which represents authority to set a pointer to a contract address at an EOA - effectively making the EOA perform as a smart contract. This change adds an optional `signEip7702Authorization` method to the `Keyring` type which is implemented on `@metamask/eth-simple-keyring` and `@metamask/eth-hd-keyring` in MetaMask/accounts#182. See https://github.com/ethereum/EIPs/blob/master/EIPS/eip-7702.md for details --------- Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EIP-7702 defines a new struct Authorization which represents authority to set a pointer to a contract address at an EOA - effectively making the EOA perform as a smart contract.
This change integrates the new
signEIP7702Authorizationadded to eth-sig-util in MetaMask/eth-sig-util#407 to the eth-simple and eth-hd keyrings.See https://github.com/ethereum/EIPs/blob/master/EIPS/eip-7702.md for details