feat: add optional signEip7702Authorization method to Keyring type
#231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit 368a7c6.
jeffsmale90
force-pushed
the
feat/7702-sign-authorization
branch
from
8b57894 to
16e4553
Compare
ccharly
changed the title
signEIP7702Authorization method to Keyring typesignEip7702Authorization method to Keyring type
ccharly
reviewed
Feb 11, 2025
| */ | ||
| signEip7702Authorization?( | ||
| address: Hex, | ||
| authorization: [chainId: number, contractAddress: Hex, nonce: number], |
There was a problem hiding this comment.
We could have used @metamask/eth-sig-util here too, but that would pull a new dep and since we plan to move this type (Keyring) to accounts/keyring-utils, I think that's fine that we keep it as is.
ccharly
previously approved these changes
Feb 11, 2025
ccharly
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EIP-7702 defines a new struct Authorization which represents authority to set a pointer to a contract address at an EOA - effectively making the EOA perform as a smart contract.
This change adds an optional
signEip7702Authorizationmethod to theKeyringtype which is implemented on@metamask/eth-simple-keyringand@metamask/eth-hd-keyringin MetaMask/accounts#182.See https://github.com/ethereum/EIPs/blob/master/EIPS/eip-7702.md for details