fix: extension bug report of 30473, user receive error when sign typed data v4 with string value of salt. #249
+182
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix the extension bug 30473
Basically the issue was caused by domain salt was defined as string in client DApp, and @metamask/eth-sig-util library we used define salt as arrayType. which cause miss match with previous code of salt value.
This code has been tested with client dapp and our e2e test-dapp to confirm it will work for both.
Examples