Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extension bug report of 30473, user receive error when sign typed data v4 with string value of salt. #249

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dawnseeker8
Copy link
Contributor

This PR is to fix the extension bug 30473

Basically the issue was caused by domain salt was defined as string in client DApp, and @metamask/eth-sig-util library we used define salt as arrayType. which cause miss match with previous code of salt value.

This code has been tested with client dapp and our e2e test-dapp to confirm it will work for both.

Examples

…th type in ledgerHQ library which require string value.

the previous code has bug to convert the string value salt to something else.
@dawnseeker8
Copy link
Contributor Author

@metamaskbot publish-preview

Copy link

Preview builds have been published. See these instructions (from the core monorepo) for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/keyring-api": "17.2.1-a272752",
  "@metamask-previews/eth-hd-keyring": "12.1.0-a272752",
  "@metamask-previews/eth-ledger-bridge-keyring": "10.0.0-a272752",
  "@metamask-previews/eth-simple-keyring": "10.0.0-a272752",
  "@metamask-previews/eth-trezor-keyring": "8.0.0-a272752",
  "@metamask-previews/keyring-internal-api": "6.0.0-a272752",
  "@metamask-previews/keyring-internal-snap-client": "4.0.1-a272752",
  "@metamask-previews/eth-snap-keyring": "12.0.0-a272752",
  "@metamask-previews/keyring-snap-client": "4.0.1-a272752",
  "@metamask-previews/keyring-snap-sdk": "3.1.0-a272752",
  "@metamask-previews/keyring-utils": "3.0.0-a272752"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-hardware-wallets This should be handled by the Hardware Wallets Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant