[Bug]: Ledger Devices signature miss match after Version 12.11.0

[bangjelkoski]

Describe the bug

After the recent update, EIP712, which gets signed on Ledger through Metamask, has a signature mismatch issue.

Expected behavior

Before this upgrade, no issues were encountered with signing EIP712 through Metamask with Ledger devices. Using Ledger directly also has no issues.

Screenshots/Recordings

No response

Steps to reproduce

1. Go to https://helixapp.com
2. Try to sign any transaction when Metamask has a Ledger device selected,

Here is a JSON that you can also use to try in unit tests:

{"types":{"EIP712Domain":[{"name":"name","type":"string"},{"name":"version","type":"string"},{"name":"chainId","type":"uint256"},{"name":"verifyingContract","type":"address"},{"name":"salt","type":"string"}],"Tx":[{"name":"context","type":"string"},{"name":"msgs","type":"string"}]},"primaryType":"Tx","domain":{"name":"Injective Web3","version":"1.0.0","chainId":"0x1","verifyingContract":"0xCcCCccccCCCCcCCCCCCcCcCccCcCCCcCcccccccC","salt":"0"},"message":{"context":"{\"account_number\":28013,\"chain_id\":\"injective-1\",\"fee\":{\"amount\":[{\"denom\":\"inj\",\"amount\":\"105102000000000\"}],\"gas\":210204,\"payer\":\"inj1065f86fh88ptyrg8h5048zu0vyx7ex8ymwgr6h\"},\"memo\":\"\",\"sequence\":1096,\"timeout_height\":106702014}","msgs":"[{\"@type\":\"/injective.exchange.v1beta1.MsgCreateDerivativeLimitOrder\",\"sender\":\"inj1xpc7l2k9l7mqyctdqjpt37wwfc7gqj7nt3vhy4\",\"order\":{\"market_id\":\"0x4ca0f92fc28be0c9761326016b5a1a2177dd6375558365116b5bdda9abc229ce\",\"order_info\":{\"subaccount_id\":\"0x3071efaac5ffb602616d0482b8f9ce4e3c804bd3000000000000000000000000\",\"fee_recipient\":\"inj1jv65s3grqf6v6jl3dp4t6c9t9rk99cd8dkncm8\",\"price\":\"92500000000.000000000000000000\",\"quantity\":\"0.001000000000000000\",\"cid\":\"\"},\"order_type\":\"BUY\",\"margin\":\"92500000.000000000000000000\",\"trigger_price\":\"0.000000000000000000\"}}]"}}

Error messages or log output

Error thrown in the console


{
    "code": -32603,
    "message": "Keyring Controller signTypedMessage: Error: Ledger: The signature doesnt match the right address",
    "data": {
        "cause": {
            "stack": "Error: Keyring Controller signTypedMessage: Error: Ledger: The signature doesnt match the right address\n  at me.signTypedMessage (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-1.js:1:480764)\n  at async L.d (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-2.js:5:10943)\n  at async L.m (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-2.js:5:10522)\n  at async L.c (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-2.js:5:8635)\n  at async s (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background-0.js:1:31933)\n  at async chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-0.js:1:522117\n  at async chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-1.js:1:96936",
            "message": "Keyring Controller signTypedMessage: Error: Ledger: The signature doesnt match the right address"
        }
    }
}

Detection stage

In production (default)

Version

12.11.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

[vivek-consensys]

When swapping USDT to INJ, I am receiving another error on console.
bugsnag.js:2401 MetamaskException: Please connect directly with Ledger instead through to sign this transaction | {"type":"wallet-error","code":-1,"errorClass":"MetamaskException","message":"Please connect directly with Ledger instead through to sign this transaction","contextModule":"sign-transaction","originalMessage":"Please connect directly with Ledger instead through Metamask to sign this transaction","stack":["Error: Please connect directly with Ledger instead through Metamask to sign this transaction","at Qce.signEip712TypedData (https://helixapp.com/_nuxt/D7Y9Ii6W.js:60:196339)","at async W2e.broadcastWeb3WithFeeDelegation (https://helixapp.com/_nuxt/D7Y9Ii6W.js:3:18848)","at async W2e.broadcastWithFeeDelegation (https://helixapp.com/_nuxt/D7Y9Ii6W.js:3:15546)","at async Proxy.broadcastWithFeeDelegation (https://helixapp.com/_nuxt/B9etIFFg.js:8:4427643)","at async Proxy.X (https://helixapp.com/_nuxt/ZWJBKkSg.js:1:1892)"]} at Qce.signEip712TypedData (https://helixapp.com/_nuxt/D7Y9Ii6W.js:60:196339) at async W2e.broadcastWeb3WithFeeDelegation (https://helixapp.com/_nuxt/D7Y9Ii6W.js:3:18848) at async W2e.broadcastWithFeeDelegation (https://helixapp.com/_nuxt/D7Y9Ii6W.js:3:15546) at async Proxy.broadcastWithFeeDelegation (https://helixapp.com/_nuxt/B9etIFFg.js:8:4427643) at async Proxy.X (https://helixapp.com/_nuxt/ZWJBKkSg.js:1:1892)

Private Zenhub Video

[bangjelkoski]

When swapping USDT to INJ, I am receiving another error on console. bugsnag.js:2401 MetamaskException: Please connect directly with Ledger instead through to sign this transaction | {"type":"wallet-error","code":-1,"errorClass":"MetamaskException","message":"Please connect directly with Ledger instead through to sign this transaction","contextModule":"sign-transaction","originalMessage":"Please connect directly with Ledger instead through Metamask to sign this transaction","stack":["Error: Please connect directly with Ledger instead through Metamask to sign this transaction","at Qce.signEip712TypedData (https://helixapp.com/_nuxt/D7Y9Ii6W.js:60:196339)","at async W2e.broadcastWeb3WithFeeDelegation (https://helixapp.com/_nuxt/D7Y9Ii6W.js:3:18848)","at async W2e.broadcastWithFeeDelegation (https://helixapp.com/_nuxt/D7Y9Ii6W.js:3:15546)","at async Proxy.broadcastWithFeeDelegation (https://helixapp.com/_nuxt/B9etIFFg.js:8:4427643)","at async Proxy.X (https://helixapp.com/_nuxt/ZWJBKkSg.js:1:1892)"]} at Qce.signEip712TypedData (https://helixapp.com/_nuxt/D7Y9Ii6W.js:60:196339) at async W2e.broadcastWeb3WithFeeDelegation (https://helixapp.com/_nuxt/D7Y9Ii6W.js:3:18848) at async W2e.broadcastWithFeeDelegation (https://helixapp.com/_nuxt/D7Y9Ii6W.js:3:15546) at async Proxy.broadcastWithFeeDelegation (https://helixapp.com/_nuxt/B9etIFFg.js:8:4427643) at async Proxy.X (https://helixapp.com/_nuxt/ZWJBKkSg.js:1:1892)

Private Zenhub Video

Yes, we had to do this because signing using Ledger through Metamask doesn't work after the upgrade. If you want, I can also redeploy the product with logging for the original error.

[bangjelkoski]

Any updates here?

[dawnseeker8]

The error for
| Keyring Controller signTypedMessage: Error: Ledger: The signature doesnt match the right address

will happen only when your account address connected to wrong ledger devices, this issue most likely happen to multiple ledger devices connection issue

[bangjelkoski]

The error for | Keyring Controller signTypedMessage: Error: Ledger: The signature doesnt match the right address

will happen only when your account address connected to wrong ledger devices, this issue most likely happen to multiple ledger devices connection issue

What does this mean? I'm sure the address connected on Metamask and the one that I request signature for are the same

[dawnseeker8]

hi, @bangjelkoski I just check whether account your dapp connect to was from other ledger device or not. since we face a multiple ledger device support when user import multiple ledger accounts from more than two ledger devices, and we have enhance request logged to fix this issue.

Currently i am trying to replicate your your issue.

[dawnseeker8]

Yes, we had to do this because signing using Ledger through Metamask doesn't work after the upgrade. If you want, I can also redeploy the product with logging for the original error.

HI, @bangjelkoski can you redeploy the product so that i can try to replicate the Error: Ledger: The signature doesnt match the right address. the error message MetamaskException: Please connect directly with Ledger instead through to sign this transaction look like not from our metamask code base and ledger code base.

[bangjelkoski]

I've deployed a simple UI that you can use to replicate the error. It's basically a simple transfer between two wallets https://injective-mm-ledger-bug.netlify.app/

If you need some INJ on mainnet to test, let me know.

[quanglefed]

I’ve looked into this issue and found that removing the salt in EIP712Domain makes Metamask work. However, without the salt, we risk two issues: Replay Attacks and Collisions.

btw, this is a Metamask issue that has occurred in the past few weeks, and I’m not sure why.

[dawnseeker8]

I’ve looked into this issue and found that removing the salt in EIP712Domain makes Metamask work. However, without the salt, we risk two issues: Replay Attacks and Collisions.

btw, this is a Metamask issue that has occurred in the past few weeks, and I’m not sure why.

Recently we include the ledger clear signing support which ledger team ask us to support. thank you for sharing, @quanglefed i will have a look and debug the code using @bangjelkoski dapp.

@bangjelkoski can you send me some INJ on mainnet to this ledger address 0xBf6916f52edC86D38Da09579936a2fDfa774f21B

thank you very much for your help.

[bangjelkoski]

Sent 0.1 INJ https://www.injscan.com/account/inj1ha53dafwmjrd8rdqj4uex630m7nhfusmae3cny/

[dawnseeker8]

hi, @bangjelkoski thank you fund and i have debugged the metamask extension code with your dapp. and has found out the root cause of the issue. and i have make a fix in one of our metamask library for ledger. here is PR

I have tested the code change and confirm it will work with your dapp with domain salt value. here is some transaction details confirm i have sent 0.001 INJ to my another ledger account. https://injscan.com/transaction/740492AF58317B0E6B546ED119C85941277380FDBBAF3B0BB2786BC8370CE94A/

i will talk to my manager to priority this so that the fix can be included in to next possible release as soon as possible.

[bangjelkoski]

This is great news; thank you!

[quanglefed]

thanks @dawnseeker8, please ensure the domain salt value is added in tests and test-dapp for future compatibility.

[bangjelkoski]

Any updates here?