fix wallet_createSessionUnsupportedScopesExample #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
jiexi
approved these changes
Mar 28, 2025
adonesky1
deleted the
ad/fix-wallet_createSessionUnsupportedScopesExample
branch
adonesky1
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Apr 5, 2025
…eateSession` call (#31400) [Originally pointed this at main](#31375), but API-Specs need to be updated: MetaMask/api-specs#299 And then become dependent on a version bump that will contain changes that were introduced only on this branch so far (0.12.0) ## **Related issues** Fixes: https://github.com/orgs/MetaMask/projects/146/views/6?pane=issue&itemId=103939579&issue=MetaMask%7CMetaMask-planning%7C4544 ## **Manual testing steps** 1. Start a flask build on this branch 2. Go to https://metamask.github.io/test-dapp-multichain/latest/ 3. Select one network in the checkboxes that is not in your wallet <img width="412" alt="Screenshot 2025-03-27 at 5 12 34 PM" src="https://github.com/user-attachments/assets/8e38d849-13cb-4ca4-b69c-2ab899b161a8" /> Make sure that no other checkboxes are checked 4. Click `wallet_createSession` 5. See error in console: ``` Error creating session: Error: Requested scopes are not supported ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New error thrown if no requested scopes are supported: MetaMask/metamask-extension#31400