Skip to content

Conversation

@adonesky1
Copy link
Contributor

@adonesky1 adonesky1 commented Mar 28, 2025

Originally pointed this at main,
but API-Specs need to be updated: MetaMask/api-specs#299

And then become dependent on a version bump that will contain changes that were introduced only on this branch so far (0.12.0)

Related issues

Fixes: https://github.com/orgs/MetaMask/projects/146/views/6?pane=issue&itemId=103939579&issue=MetaMask%7CMetaMask-planning%7C4544

Manual testing steps

  1. Start a flask build on this branch
  2. Go to https://metamask.github.io/test-dapp-multichain/latest/
  3. Select one network in the checkboxes that is not in your wallet
Screenshot 2025-03-27 at 5 12 34 PM Make sure that no other checkboxes are checked 4. Click `wallet_createSession` 5. See error in console: ``` Error creating session: Error: Requested scopes are not supported ```

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@adonesky1 adonesky1 force-pushed the ad/wallet_createSession-error-when-no-scopes-supported-sip26 branch from 97ed1c1 to e6b83ed Compare April 4, 2025 17:56
@adonesky1 adonesky1 marked this pull request as ready for review April 4, 2025 17:58
@metamaskbot
Copy link
Collaborator

Builds ready [e6b83ed]
UI Startup Metrics (1282 ± 69 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1282115014806913301406
load11199671342731184967
domContentLoaded11119611331741189972
domInteractive201480141769
firstPaint796881343440219279
backgroundConnect9440679
firstReactRender2516182192350
getState13445879
initialActions001000
loadScripts852704106772897954
setupStore9533489
WebpackHomeuiStartup22081803264919223342485
load17301396225415718191968
domContentLoaded17221392224815518081952
domInteractive181379121555
firstPaint172743436222982
backgroundConnect3110352423072
firstReactRender191563881145996
getState1432982959
initialActions319135
loadScripts17181391224515418011931
setupStore227280362808
FirefoxBrowserifyHomeuiStartup13541166196415513751715
load12101044181614512271510
domContentLoaded12101044181514512271510
domInteractive9538192258795
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect20126492045
firstReactRender23196152229
getState8349779
initialActions001001
loadScripts11921030178714312091496
setupStore5410167
WebpackHomeuiStartup15111301226916315421876
load13031131203615013141623
domContentLoaded13031131203615013131623
domInteractive9337160248895
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect20134152232
firstReactRender34285053644
getState8439578
initialActions002111
loadScripts12841116202015012971605
setupStore7520279

@adonesky1 adonesky1 merged commit b40e5d5 into sip-26 Apr 5, 2025
161 checks passed
@adonesky1 adonesky1 deleted the ad/wallet_createSession-error-when-no-scopes-supported-sip26 branch April 5, 2025 22:48
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template team-wallet-api-platform-deprecated DEPRECATED: please use "team-wallet-integrations" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants