Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ethereumjs-util@6 #142

Merged
merged 4 commits into from
Aug 13, 2019
Merged

Conversation

whymarrh
Copy link
Contributor

@whymarrh whymarrh commented Aug 12, 2019

This PR updates the direct ethereumjs-util dependency to v6, which includes TypeScript definitions. There are no relevant breaking changes to GABA's direct usage:[1]

  • [BREAKING] Fixed signature to comply with Geth and Parity in toRpcSig() changing
    v from 0/1 to 27/28, this changes the resulting signature buffer, see PR #139
  • [BREAKING] Remove deprecated sha3-named constants and methods (see v5.2.0 release),
    see PR #154

I've changed the places where ethereumjs-util are being require'd to use TypeScript imports where possible (minus BN whose types don't match the usages and #141).

@codecov-io
Copy link

codecov-io commented Aug 13, 2019

Codecov Report

Merging #142 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop   #142   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files           21     21           
  Lines         1430   1432    +2     
  Branches       192    192           
======================================
+ Hits          1430   1432    +2
Impacted Files Coverage Δ
src/user/PreferencesController.ts 100% <100%> (ø) ⬆️
src/transaction/TransactionController.ts 100% <100%> (ø) ⬆️
src/keyring/KeyringController.ts 100% <100%> (ø) ⬆️
src/assets/TokenRatesController.ts 100% <100%> (ø) ⬆️
src/util.ts 100% <100%> (ø) ⬆️
src/assets/AssetsController.ts 100% <100%> (ø) ⬆️
src/assets/AssetsDetectionController.ts 100% <100%> (ø) ⬆️
src/user/AddressBookController.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7ebfdf...3ea4343. Read the comment docs.

@whymarrh whymarrh merged commit 8b15715 into MetaMask:develop Aug 13, 2019
@whymarrh whymarrh deleted the ethereumjs-util-6 branch August 13, 2019 20:12
bitpshr pushed a commit that referenced this pull request Aug 20, 2019
* Update direct dep to ethereumjs-util@6

* Update ethereumjs-util imports where possible
kanthesha pushed a commit that referenced this pull request Oct 11, 2023
Revert "7.0.0 (#141)"

This reverts commit c753c16.
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
* Update direct dep to ethereumjs-util@6

* Update ethereumjs-util imports where possible
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
* Update direct dep to ethereumjs-util@6

* Update ethereumjs-util imports where possible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants