Skip to content
This repository has been archived by the owner on Jun 17, 2021. It is now read-only.

Fixed signature to comply to Geth and Parity (see #131) #139

Merged
merged 3 commits into from
Jul 6, 2018
Merged

Fixed signature to comply to Geth and Parity (see #131) #139

merged 3 commits into from
Jul 6, 2018

Conversation

Neurone
Copy link
Contributor

@Neurone Neurone commented Jul 4, 2018

No description provided.

@coveralls
Copy link

coveralls commented Jul 4, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 99.2% when pulling 64b662e on Neurone:master into 76c0809 on ethereumjs:master.

@holgerd77
Copy link
Member

You still have a linting error here which needs to be fixed to have Travis passed (run: npm run lint for more information).

@Neurone
Copy link
Contributor Author

Neurone commented Jul 5, 2018

@holgerd77 Fixed linting errors;

holgerd77
holgerd77 approved these changes Jul 6, 2018
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the long discussion on this!

@holgerd77 holgerd77 merged commit 19d2b1f into ethereumjs:master Jul 6, 2018
@whymarrh whymarrh mentioned this pull request Aug 12, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Nov 25, 2019
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Neurone @coveralls @holgerd77