-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ethjs packages with @metamask/ethjs forks #2064
Conversation
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
…-http to @metamask/ethjs-provider-http
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
|
5a4954c
to
4cf75e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the places we are using these packages are in tests, so there is an opportunity to remove usage entirely, but we can leave that for another PR. Looks good.
Isn't the point of using it in tests to preserve compatibility with existing downstream use, ie extension and mobile? That is, they should be removed there before being removed as tests here. |
Sure, we can definitely wait until we remove them from the clients before removing them here. |
Explanation
Use MetaMask forks of ethjs packages. This is the first step of a gradual update which will result in removing dependency on
babel-runtime@6.x
, amongst other improvements.References
Related
Changelog
@metamask/controller-utils
ethjs-unit
to@metamask/ethjs-unit
@metamask/gas-fee-controller
ethjs-unit
to@metamask/ethjs-unit
@metamask/assets-controllers
ethjs-provider-http
to@metamask/ethjs-provider-http
@metamask/transactions-controller
ethjs-provider-http
to@metamask/ethjs-provider-http
Checklist