Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: ethjs@^0.4.0 -> @metamask/ethjs@^0.5.0 #50

Merged
merged 1 commit into from
Dec 9, 2023
Merged

deps: ethjs@^0.4.0 -> @metamask/ethjs@^0.5.0 #50

merged 1 commit into from
Dec 9, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Nov 20, 2023 •
edited
Loading

@socket-security Socket Security
Copy link

socket-security bot commented Nov 20, 2023 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/ethjs 0.5.1 environment +10 4.27 MB lgbot

🚮 Removed packages: ethjs@0.4.0

@legobeat legobeat added the dependencies Pull requests that update a dependency file label Nov 20, 2023
This was referenced Nov 20, 2023
Merged
Merged
Open
@socket-security Socket Security
Copy link

socket-security bot commented Dec 4, 2023 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@legobeat
Copy link
Contributor Author

legobeat commented Dec 4, 2023 

@SocketSecurity ignore @metamask/ethjs-query@0.5.3

@legobeat legobeat force-pushed the deps-ethjs branch 2 times, most recently from bc8866e to c64d91d Compare December 8, 2023 21:33
@legobeat legobeat marked this pull request as ready for review December 8, 2023 21:34
@legobeat legobeat requested a review from a team as a code owner December 8, 2023 21:34
@legobeat legobeat requested review from a team December 8, 2023 21:37
mcmire
mcmire approved these changes Dec 9, 2023
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@legobeat legobeat merged commit e5c85e1 into MetaMask:main Dec 9, 2023
@legobeat legobeat deleted the deps-ethjs branch December 9, 2023 01:28
@legobeat legobeat mentioned this pull request Dec 11, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire approved these changes

@NicholasEllul NicholasEllul Awaiting requested review from NicholasEllul

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legobeat @mcmire