-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update GHA workflows to support assisted publishing #46
Conversation
238579d
to
6d8d7f7
Compare
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
new author ok |
4e4b2dc
to
23f07bb
Compare
8d93de7
to
6442c0f
Compare
6442c0f
to
3756f1c
Compare
How urgent is this PR? I think it would be better if we could upgrade to Yarn v3 and bump the minimum Node version to 12. That would save us time in maintaining this package long-term, since we wouldn't have to manage it as differently as other libraries. But please let me know how this fits into the bigger picture on your end. |
I think release of merged #50 should happen before those two things and is more time-sensitive. This PR was intended to facilitate release and publish of it. |
3756f1c
to
0094896
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Borrowed and amended from https://github.com/MetaMask/detect-provider/ which is also a yarn v1 repo.
create-release-pr
workflownpm-publish
workflownpm-publish
GH repo environmentubuntu-20.04
toubuntu-latest
@metamask/auto-changelog
Blocked by