Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete network status controller #298

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Nov 9, 2020

Deletes the network status controller and removes all references thereto.

Verified

This commit was signed with the committer’s verified signature.
AmineChikhaoui Amine Chikhaoui
Copy link
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rekmarks
Copy link
Member Author

rekmarks commented Nov 9, 2020

I don't know why it keeps doing this, but the status checks aren't happening even though the pipeline is passing: https://app.circleci.com/pipelines/github/MetaMask/controllers?branch=delete-network-status-controller

@rekmarks rekmarks merged commit cba7aa1 into develop Nov 9, 2020
@rekmarks rekmarks deleted the delete-network-status-controller branch November 9, 2020 17:01
@rekmarks rekmarks mentioned this pull request Nov 9, 2020
MajorLift pushed a commit that referenced this pull request Oct 11, 2023

Verified

This commit was signed with the committer’s verified signature.
AmineChikhaoui Amine Chikhaoui
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants