Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove network status controller #1970

Merged
merged 3 commits into from
Nov 17, 2020
Merged

Remove network status controller #1970

merged 3 commits into from
Nov 17, 2020

Conversation

estebanmino
Copy link
Contributor

@estebanmino estebanmino commented Nov 9, 2020 •
edited
Loading

Description

MetaMask/core#298

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@estebanmino estebanmino requested a review from a team as a code owner November 9, 2020 16:28
Gudahtt
Gudahtt previously approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disregard; I accidentally approved the wrong tab 🤦 I had two open alongside each other.

@Gudahtt Gudahtt dismissed their stale review November 9, 2020 16:55

Accidental

@andrepimenta andrepimenta mentioned this pull request Nov 16, 2020
Merged
@estebanmino estebanmino merged commit 00e2ea9 into develop Nov 17, 2020
@estebanmino estebanmino deleted the remove-network-status branch November 17, 2020 17:53
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino
Remove network status controller (#1970)
9d34449 
* rm

* test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickycodes rickycodes rickycodes approved these changes

@Gudahtt Gudahtt Gudahtt left review comments

Assignees
No one assigned
Labels
next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@estebanmino @rickycodes @Gudahtt @omnat